Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused method CreateProjectPost #18129

Merged
merged 2 commits into from
Dec 30, 2021

Conversation

KN4CK3R
Copy link
Member

@KN4CK3R KN4CK3R commented Dec 29, 2021

The method was added in #8346 but never used.

@KN4CK3R KN4CK3R added type/refactoring Existing code has been cleaned up. There should be no new functionality. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Dec 29, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Dec 30, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 30, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #18129 (bf56caf) into main (e4e3df6) will increase coverage by 0.02%.
The diff coverage is 68.79%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #18129      +/-   ##
==========================================
+ Coverage   44.89%   44.91%   +0.02%     
==========================================
  Files         824      824              
  Lines       91581    91530      -51     
==========================================
- Hits        41111    41107       -4     
+ Misses      43879    43846      -33     
+ Partials     6591     6577      -14     
Impacted Files Coverage Δ
models/repo/repo.go 67.93% <ø> (+1.90%) ⬆️
models/repo_permission.go 58.96% <ø> (+2.07%) ⬆️
models/user.go 31.03% <ø> (-6.28%) ⬇️
routers/web/repo/projects.go 16.26% <ø> (+0.84%) ⬆️
routers/web/web.go 90.37% <ø> (-0.02%) ⬇️
models/repo/repo_list.go 38.09% <38.09%> (ø)
models/issue.go 59.18% <63.79%> (+0.21%) ⬆️
models/repo_list.go 77.21% <70.07%> (-5.98%) ⬇️
services/repository/push.go 53.05% <71.42%> (+0.39%) ⬆️
routers/web/user/home.go 63.83% <78.57%> (+4.27%) ⬆️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccb7978...bf56caf. Read the comment docs.

@wxiaoguang wxiaoguang merged commit 658a636 into go-gitea:main Dec 30, 2021
zjjhot added a commit to zjjhot/gitea that referenced this pull request Dec 30, 2021
* giteaoffical/main:
  Fix wrong redirect on org labels (go-gitea#18128)
  Fix performance regression when user has many organization (go-gitea#18125)
  docs: add various ways to install from package (go-gitea#18120)
  Removed unused method. (go-gitea#18129)
  [skip ci] Updated translations via Crowdin
  Removed unused endpoint. (go-gitea#18127)
@KN4CK3R KN4CK3R deleted the refactor-createprojectpost branch March 23, 2022 19:54
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants