Prevent NPE on partial match of compare URL (part 2) #18490
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately go-gitea#18472 only fixed part of the ways a nil pointer can occur in the compare url. We also need to ensure that the match array has all the matches present. Fix go-gitea#18471 Related go-gitea#18472 Signed-off-by: Andrew Thornton <[email protected]>
zeripath
added
type/bug
skip-changelog
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Jan 31, 2022
Backport go-gitea#18490 Unfortunately go-gitea#18472 only fixed part of the ways a nil pointer can occur in the compare url. We also need to ensure that the match array has all the matches present. Fix go-gitea#18471 Related go-gitea#18472 Signed-off-by: Andrew Thornton <[email protected]>
|
Ignore me I'm an idiot! |
GiteaBot
added
the
lgtm/need 2
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately #18472 only fixed part of the ways a nil pointer can occur in the
compare url. We also need to ensure that the match array has all the matches present.
Fix #18471
Related #18472
Signed-off-by: Andrew Thornton [email protected]