Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build with node16 in snap #18508

Merged
merged 2 commits into from
Jan 31, 2022
Merged

build with node16 in snap #18508

merged 2 commits into from
Jan 31, 2022

Conversation

techknowlogick
Copy link
Member

as title

@techknowlogick techknowlogick added topic/distribution This PR changes something about the packaging of Gitea skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Jan 31, 2022
@techknowlogick techknowlogick added this to the 1.17.0 milestone Jan 31, 2022
techknowlogick
techknowlogick commented Jan 31, 2022
View reviewed changes
snap/snapcraft.yaml
@@ -67,6 +67,7 @@ parts:

override-build: |
set -x
sed -i 's/os.Getuid()/1/g' modules/setting/setting.go
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

snap runs as root hence the sed cmd.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 31, 2022
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 31, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 31, 2022
@techknowlogick techknowlogick merged commit 70e614b into go-gitea:main Jan 31, 2022
@techknowlogick techknowlogick deleted the snap-upse-node16 branch January 31, 2022 22:52
zjjhot added a commit to zjjhot/gitea that referenced this pull request Feb 2, 2022
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
8503c0b 
* giteaofficial/main: (37 commits)
  Collaborator trust model should trust collaborators (go-gitea#18539)
  Detect conflicts with 3way merge (go-gitea#18536)
  [skip ci] Updated translations via Crowdin
  Update 1.16.0 changelog to set go-gitea#17846 as breaking (go-gitea#18533)
  In docker rootless use $GITEA_APP_INI if provided (go-gitea#18524)
  revert to node14 for snapcraft
  Add `GetUserTeams` (go-gitea#18499)
  Fix review excerpt (go-gitea#18502)
  Update JS dependencies, fix lint (go-gitea#18389)
  add test coverage for original author conversion during migrations (go-gitea#18506)
  add gitea-fmt back (go-gitea#18526)
  Fix non-ASCII search on database  (go-gitea#18437)
  Use "read" value for General Access (go-gitea#18496)
  Fix for AvatarURL database type (go-gitea#18487)
  Remove go 1.15 support (go-gitea#18511)
  [skip ci] Updated translations via Crowdin
  Use `ImagedProvider` for gplus oauth2 provider (go-gitea#18504)
  build with node16 in snap (go-gitea#18508)
  point to s3 endpoint directly (go-gitea#18497)
  Fix OAuth Source Edit Page (go-gitea#18495)
  ...
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
@techknowlogick
build with node16 in snap (go-gitea#18508)
45c47a9
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Gusted Gusted Gusted approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/distribution This PR changes something about the packaging of Gitea
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.
4 participants
@techknowlogick @6543 @Gusted @GiteaBot