Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent dangling GetAttribute calls (#18754) #18755

Conversation

zeripath
Copy link
Contributor

@zeripath zeripath commented Feb 13, 2022

Backport #18754

It appears possible that there could be a hang due to unread data from the
repo-attribute command pipes. This PR simply closes these during the defer.

Fix #18734

Signed-off-by: Andrew Thornton [email protected]

It appears possible that there could be a hang due to unread data from the
repo-attribute command pipes. This PR simply closes these during the defer.

Signed-off-by: Andrew Thornton <[email protected]>
@zeripath zeripath added this to the 1.16.2 milestone Feb 13, 2022
@zeripath zeripath linked an issue Feb 14, 2022 that may be closed by this pull request
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 14, 2022
Copy link

@115ek 115ek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified this changeset to be fixing #18734
Tested on win11 with git 2.35.1.windows.2

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 14, 2022
@techknowlogick techknowlogick merged commit 7ebc3da into go-gitea:release/v1.16 Feb 14, 2022
@zeripath zeripath deleted the fix-dangling-get-attributes-1.16 branch February 14, 2022 20:46
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Git.exe Processes Hanging / Not Cleaning Up
5 participants