-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ldap user sync missed email in email_address table #18786
Conversation
If old email address source is LDAP, it should be deleted |
CI failure is related |
We don't know that. LDAP user could add a new email address and change the primary email. So let it be and user could delete the old email manually. |
326bd00
to
37d8a7b
Compare
Codecov Report
@@ Coverage Diff @@
## main #18786 +/- ##
=======================================
Coverage ? 46.61%
=======================================
Files ? 853
Lines ? 122512
Branches ? 0
=======================================
Hits ? 57111
Misses ? 58507
Partials ? 6894
Continue to review full report at Codecov.
|
* giteaofficial/main: Fix ldap user sync missed email in email_address table (go-gitea#18786) Update assignees check to include any writing team and change org sidebar (go-gitea#18680) Set max text height to prevent overflow (go-gitea#18862) Lock gofumpt to v0.3.0 and run it (go-gitea#18866)
IsActivated: true, | ||
IsPrimary: true, | ||
}) | ||
return err |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be if err != nil {
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch
* Fix ldap user sync missed email in email_address table * Fix test
* Fix ldap user sync missed email in email_address table * Fix test
Fix #18603 . Should we keep the old email address or delete it when sync user with new email from ldap?