Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug where certain LDAP settings were reverted #18859

Merged
merged 1 commit into from
Feb 22, 2022
Merged

Fix bug where certain LDAP settings were reverted #18859

merged 1 commit into from
Feb 22, 2022

Conversation

lunny
Copy link
Member

@lunny lunny commented Feb 22, 2022

backport #18856

@lunny lunny added the type/bug label Feb 22, 2022
@lunny lunny added this to the 1.16.2 milestone Feb 22, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 22, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 22, 2022
@techknowlogick techknowlogick merged commit efc78c1 into go-gitea:release/v1.16 Feb 22, 2022
@techknowlogick techknowlogick changed the title Fix ldap edit bug Fix bug where certain LDAP settings were reverted Feb 22, 2022
@lunny lunny deleted the lunny/fix_ldap_bug2 branch February 24, 2022 01:55
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@richmahn richmahn richmahn approved these changes

@silverwind silverwind silverwind approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.16.2
Development

Successfully merging this pull request may close these issues.
5 participants
@lunny @silverwind @richmahn @techknowlogick @GiteaBot