Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder issue templates and automatically add labels #18875

Merged
merged 9 commits into from
Mar 21, 2022

Conversation

delvh
Copy link
Member

@delvh delvh commented Feb 24, 2022

It annoyed me that the issue description which is the most vital part of an issue was displayed at the end, resulting in long scrolling.
Hence, I reordered the issue templates so that the information I deem most relevant is displayed at the top.
Apart from the description, this includes a relocation of the "Can you confirm this on try.gitea.io?" question and of the logs and screenshots.

Additionally, I added applicable labels on each template so that every bug will be auto-labeled kind/bug, and every feature request will automatically be labeled kind/feature.

@delvh delvh added this to the 1.17.0 milestone Feb 24, 2022
@delvh delvh self-assigned this Feb 24, 2022
@delvh delvh added type/docs This PR mainly updates/creates documentation type/miscellaneous priority/low skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. and removed type/docs This PR mainly updates/creates documentation labels Feb 24, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 25, 2022
@@ -1,5 +1,6 @@
name: Feature Request
description: Got an idea for a feature that Gitea doesn't have currently? Submit your idea here!
labels: kind/feature
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe proposal as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, the problem I have with that is:
What exactly is the difference between feature and proposal?
I've seen both used, but for me, they mean pretty much the same thing.
I mean, I can add it, but aren't these two labels simply duplicates? Or do I understand something wrong?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added it now. However, I still would like to know the difference between kind/proposal and kind/feature.

.github/ISSUE_TEMPLATE/ui.bug-report.yaml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug-report.yaml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/ui.bug-report.yaml Outdated Show resolved Hide resolved
@delvh
Copy link
Member Author

delvh commented Feb 28, 2022

Ping, @jpraet @techknowlogick

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 28, 2022
@lunny
Copy link
Member

lunny commented Mar 21, 2022

make L-G-T-M work.

@lunny lunny merged commit bfe2e3d into go-gitea:main Mar 21, 2022
a1012112796 added a commit to a1012112796/gitea that referenced this pull request Mar 21, 2022
* main:
  Reorder issue templates and automatically add labels (go-gitea#18875)
  Use IterateBufferSize whilst querying repositories during adoption check (go-gitea#19140)
  Add 1.18 (go-gitea#19151)
  [skip ci] Updated translations via Crowdin
  Fix NPE `/repos/issues/search` when not signed in (go-gitea#19154)
@delvh delvh deleted the update-issue-templates branch March 21, 2022 14:05
@delvh
Copy link
Member Author

delvh commented Mar 21, 2022

finally 😌

zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 22, 2022
* giteaofficial/main:
  Fix the bug: deploy key with write access can not push (go-gitea#19010)
  Renamed ctx.User to ctx.Doer. (go-gitea#19161)
  [docs] Enhance container selection in docker dump (go-gitea#14292)
  Cleanup protected branches when deleting users & teams (go-gitea#19158)
  Reorder issue templates and automatically add labels (go-gitea#18875)
  Use IterateBufferSize whilst querying repositories during adoption check (go-gitea#19140)
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
* Reorder bug-report.yaml

* Add bug label on bug-report.yaml

* Add feature label on feature-request.yaml

* Reorder ui.bug-report.yaml

* Apply suggestions

Co-authored-by: Lunny Xiao <[email protected]>
Co-authored-by: 6543 <[email protected]>
Co-authored-by: zeripath <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/miscellaneous
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants