Ensure isSSH is set whenever DISABLE_HTTP_GIT is set

[zeripath]

In clone_buttons.tmpl the defer block sets the javascript isSSH variable.
When DISABLE_HTTP_GIT is set we should always set this to true.

Fix #19020

Signed-off-by: Andrew Thornton [email protected]

[zeripath]

Great lint is not allowing the obvious solution.

[techknowlogick]

Suggested change

	const isSSH = httpsDisabled || localStorage.getItem('repo-clone-protocol') === 'ssh';
	const isSSH = {{if $.DisableHTTP}}true || {{end}}localStorage.getItem('repo-clone-protocol') === 'ssh';

A suggestion: this changes this PR to one line vs 10. Feel free to take it or discard, although if discarded then the above code chunk could have some de-duplication.

[zeripath]

that will fail our lint

[zeripath]

(I tried this orignally)

[lunny]

But how about when they disabled both HTTP and SSH? Just use the UI?

[techknowlogick]

😭 ah, I see.

[wxiaoguang]

We can bypass the JS linter for some code blocks. See the head.tmpl

[wxiaoguang]

I think these JS code should be refactored. For example:

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/script

Warning: This attribute  (defer) must not be used if the src attribute is absent (i.e. for inline scripts), in this case it would have no effect.

[wxiaoguang]

It could be refactored to the following code.

Benefits:

1. No more global variable pollution, every variable is in their own scope pageData and (()=>{})()
2. The major code is still linted by linter.
3. DisableHTTP can be encoded by html template to JSON automatically.

{{if not (and $.DisableHTTP $.DisableSSH)}}
	<script>
		<!-- /* eslint-disable */ -->
		window.config.pageData['repoCloneButtons'] = {httpsDisabled: {{$.DisableHTTP}}};
	</script>
	<script>
		(() => {
			const tmplData = window.config.pageData.repoCloneButtons;
			const isSSH = tmplData.httpsDisabled || localStorage.getItem('repo-clone-protocol') === 'ssh';
			const sshButton = document.getElementById('repo-clone-ssh');
			const httpsButton = document.getElementById('repo-clone-https');
			const input = document.getElementById('repo-clone-url');
			if (input) input.value = (isSSH ? sshButton : httpsButton).getAttribute('data-link');
			if (sshButton) sshButton.classList[isSSH ? 'add' : 'remove']('primary');
			if (httpsButton) httpsButton.classList[isSSH ? 'remove' : 'add']('primary');
			setTimeout(() => {
				if (sshButton) sshButton.classList.remove('no-transition');
				if (httpsButton) httpsButton.classList.remove('no-transition');
			}, 100);
		})();
	</script>
{{end}}

[zeripath]

I shall defer to @wxiaoguang

[wxiaoguang]

The new #19028 is based on this one 🙏, it could pass the lint.