Prevent 500 when there is an error during new auth source post #19041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix go-gitea#19036 Signed-off-by: Andrew Thornton <[email protected]>
lunny
approved these changes
Mar 10, 2022
GiteaBot
added
the
lgtm/need 1
|
Have you checked all the places in that templates? |
|
There is another bug reported in #19036 ( Steps:
I didn't know what's the proper way to handle the duplicated key check in Gitea. Should it use a separate SELECT to check? Or does XORM provide some error check mechanism to detect the error is caused by duplicated unique key? |
6543
approved these changes
Mar 10, 2022
GiteaBot
added
lgtm/done
|
👍 |
Please create a new issue. |
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Mar 11, 2022
* giteaofficial/main: Prevent 500 when there is an error during new auth source post (go-gitea#19041) Update the webauthn_credential_id_sequence in Postgres (go-gitea#19048) If rendering has failed due to a net.OpError stop rendering (attempt 2) (go-gitea#19049) use xorm builder for models.getReviewers() (go-gitea#19033) RSS/Atom support for Orgs (go-gitea#17714) Fix flag validation (go-gitea#19046) Improve SyncMirrors logging (go-gitea#19045)
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Mar 11, 2022
…tea#19041) Backport go-gitea#19041 Fix go-gitea#19036 Signed-off-by: Andrew Thornton <[email protected]>
6543
pushed a commit
that referenced
this pull request
Mar 13, 2022
… (#19059) Backport #19041 Fix #19036 Signed-off-by: Andrew Thornton <[email protected]>
Chianina
pushed a commit
to Chianina/gitea
that referenced
this pull request
Mar 28, 2022
…tea#19041) Fix go-gitea#19036 Signed-off-by: Andrew Thornton <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #19036
Signed-off-by: Andrew Thornton [email protected]