use go1.18 to build gitea #19099
Merged
use go1.18 to build gitea #19099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gusted
approved these changes
Mar 15, 2022
GiteaBot
added
the
lgtm/need 1
techknowlogick
added
pr/breaking
|
I just rebuilt my gitea package with 1.18.0 (Linux, amd64) and get a reproducible crash on startup: This worked fine when built with 1.17.8 earlier today. |
|
Need to backport #18644 |
|
Missed a few places for updating minimum go version, like in README. |
Gusted
reviewed
Mar 15, 2022
modules/util/net_test.go
Outdated
| } | ||
|
|
||
| for n, c := range cases { | ||
| i, _ := net.ParseIP(c.ip) |
There was a problem hiding this comment.
I don't think that we already should include go1.18 code, even for tests.
There was a problem hiding this comment.
This is go1.17 code: https://cs.opensource.google/go/go/+/refs/tags/go1.17:src/net/ip.go;l=704
Edit: This just adds tests for logic we already had
silverwind
approved these changes
Mar 16, 2022
GiteaBot
added
lgtm/done
|
golangci-lint doesn't support go1.18 yet: golangci/golangci-lint#2374 & go-critic/go-critic#1126 |
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Mar 16, 2022
* giteaoffical/main: rm .sample hooks which aren't used (go-gitea#19101) use go1.18 to build gitea (go-gitea#19099) Use `go run` for tool dependencies, require go 1.17 (go-gitea#18874) Update golang.org/x/crypto (go-gitea#19097) Handle email address not exist. (go-gitea#19089)
techknowlogick
added a commit
to techknowlogick/gitea
that referenced
this pull request
Mar 18, 2022
* use go1.18 to build gitea& update min go version to 1.17 * bump in a few more places * add a few simple tests for isipprivate * update go.mod * update URL to https://go.dev/dl/ * golangci-lint * attempt golangci-lint workaround * change version * bump fumpt version * skip strings.title test * go mod tidy * update tests as some aren't private?? * update tests
6543
added a commit
that referenced
this pull request
Mar 19, 2022
Backport #19120 Backport #19099 Backport #18874 Backport #18420 Backport #19128 Backport #18270 Bump to build with go1.18 Co-authored-by: techknowlogick <[email protected]> Signed-off-by: Andrew Thornton <[email protected]> Co-authored-by: silverwind <[email protected]> Co-authored-by: 6543 <[email protected]> Co-authored-by: zeripath <[email protected]> Co-authored-by: Jelle Hulter <[email protected]>
Chianina
pushed a commit
to Chianina/gitea
that referenced
this pull request
Mar 28, 2022
* use go1.18 to build gitea& update min go version to 1.17 * bump in a few more places * add a few simple tests for isipprivate * update go.mod * update URL to https://go.dev/dl/ * golangci-lint * attempt golangci-lint workaround * change version * bump fumpt version * skip strings.title test * go mod tidy * update tests as some aren't private?? * update tests
6543
added
the
skip-changelog
|
-> #19918 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
& update min go version to 1.17
includes parts of #18874 (but doesn't replace that PR)
Depends on: docker-library/golang#411 & docker-library/official-images#12045