Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the new/choose link for New Issue on project page #19172

Merged
merged 6 commits into from
Mar 22, 2022
Merged

Use the new/choose link for New Issue on project page #19172

merged 6 commits into from
Mar 22, 2022

Conversation

zeripath
Copy link
Contributor

Extend issues/new/choose to pass the project id and change New Issue
link on project page to use new/choose

Fix #19170

Signed-off-by: Andrew Thornton [email protected]

@zeripath
Use the new/choose link for New Issue on project page
ed454f2 
Extend issues/new/choose to pass the project id and change New Issue
link on project page to use new/choose

Fix go-gitea#19170

Signed-off-by: Andrew Thornton <[email protected]>
@zeripath zeripath added type/enhancement An improvement of existing functionality backport/v1.16 labels Mar 22, 2022
@zeripath zeripath added this to the 1.17.0 milestone Mar 22, 2022
@wxiaoguang

This comment was marked as resolved.

Sign in to view
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 22, 2022
@zeripath

This comment was marked as resolved.

Sign in to view
@zeripath
as per review
a32bf1f 
Signed-off-by: Andrew Thornton <[email protected]>
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 22, 2022
@wxiaoguang

This comment was marked as outdated.

Sign in to view
delvh
delvh reviewed Mar 22, 2022
View reviewed changes
routers/web/repo/issue.go
ctx.Data["IssueTemplates"] = issueTemplates

if len(issueTemplates) == 0 {
ctx.Redirect(fmt.Sprintf("%s/issues/new?%s", ctx.Repo.Repository.HTMLURL(), ctx.Req.URL.RawQuery), http.StatusSeeOther)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that route correct? Shouldn't this be something like %s/issues/new?redirect=%s instead?
(I don't know how that query parameter is actually called)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested, it is correct. They share the same parameters milestone and project.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I think I misunderstood RawQuery: I interpreted it as the whole URL.
But it is only meant as the part after the ?. Then it makes sense of course.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could add a comment here why it works

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added, it is clear now?

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 22, 2022
@zeripath zeripath merged commit d2c1658 into go-gitea:main Mar 22, 2022
@zeripath zeripath deleted the fix-19170-use-choose-for-new-issue-from-project branch March 22, 2022 19:54
zeripath added a commit to zeripath/gitea that referenced this pull request Mar 22, 2022
@zeripath @wxiaoguang
Use the new/choose link for New Issue on project page (go-gitea#19172)
c87afd4 
Backport go-gitea#19172

Extend issues/new/choose to pass the project id and change New Issue
link on project page to use new/choose

Fix go-gitea#19170

Signed-off-by: Andrew Thornton <[email protected]>
Co-authored-by: wxiaoguang <[email protected]>
@zeripath zeripath mentioned this pull request Mar 22, 2022
Merged
@zeripath zeripath added the backport/done All backports for this PR have been created label Mar 22, 2022
lunny pushed a commit that referenced this pull request Mar 23, 2022
@zeripath @wxiaoguang
Use the new/choose link for New Issue on project page (#19172) (#19176)
4b7cb81 
Backport #19172

Extend issues/new/choose to pass the project id and change New Issue
link on project page to use new/choose

Fix #19170

Signed-off-by: Andrew Thornton <[email protected]>
Co-authored-by: wxiaoguang <[email protected]>

Co-authored-by: wxiaoguang <[email protected]>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 23, 2022
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
9ebc810 
* giteaofficial/main:
  Remove the Go version in UI, add a link on Gitea Version to show config details (Go/Git version) (go-gitea#19173)
  [skip ci] Updated translations via Crowdin
  Clean paths when looking in Storage (go-gitea#19124)
  Use the new/choose link for New Issue on project page (go-gitea#19172)
  Ensure that setting.LocalURL always has a trailing slash (go-gitea#19171)
  Use `ctx` instead of `db.DefaultContext` in some packages(routers/services/modules) (go-gitea#19163)
zeripath added a commit to zeripath/gitea that referenced this pull request Mar 23, 2022
@zeripath
Changelog for 1.16.5
fb7de1c 
 ## [1.16.5](https://github.com/go-gitea/gitea/releases/tag/1.16.5) - 2022-03-23

* BREAKING
  * Bump to build with go1.18 (go-gitea#19120 et al) (go-gitea#19127)
* SECURITY
  * Prevent redirect to Host (2) (go-gitea#19175) (go-gitea#19186)
  * Try to prevent autolinking of displaynames by email readers (go-gitea#19169) (go-gitea#19183)
  * Clean paths when looking in Storage (go-gitea#19124) (go-gitea#19179)
  * Do not send notification emails to inactive users (go-gitea#19131) (go-gitea#19139)
  * Do not send activation email if manual confirm is set (go-gitea#19119) (go-gitea#19122)
* ENHANCEMENTS
  * Use the new/choose link for New Issue on project page (go-gitea#19172) (go-gitea#19176)
* BUGFIXES
  * Fix compare link in active feeds for new branch (go-gitea#19149) (go-gitea#19185)
  * Redirect .wiki/* ui link to /wiki (go-gitea#18831) (go-gitea#19184)
  * Ensure deploy keys with write access can push (go-gitea#19010) (go-gitea#19182)
  * Ensure that setting.LocalURL always has a trailing slash (go-gitea#19171) (go-gitea#19177)
  * Cleanup protected branches when deleting users & teams (go-gitea#19158) (go-gitea#19174)
  * Use IterateBufferSize whilst querying repositories during adoption check (go-gitea#19140) (go-gitea#19160)
  * Fix NPE /repos/issues/search when not signed in (go-gitea#19154) (go-gitea#19155)
  * Use custom favicon when viewing static files if it exists (go-gitea#19130) (go-gitea#19152)
  * Fix the editor height in review box (go-gitea#19003) (go-gitea#19147)
  * Ensure isSSH is set whenever DISABLE_HTTP_GIT is set (go-gitea#19028) (go-gitea#19146)
  * Fix wrong scopes caused by empty scope input (go-gitea#19029) (go-gitea#19145)
  * Make migrations SKIP_TLS_VERIFY apply to git too (go-gitea#19132) (go-gitea#19141)
  * Handle email address not exist (go-gitea#19089) (go-gitea#19121)
* MISC
  * Update json-iterator to allow compilation with go1.18 (go-gitea#18644) (go-gitea#19100)
  * Update golang.org/x/crypto (go-gitea#19097) (go-gitea#19098)

Signed-off-by: Andrew Thornton <[email protected]>
@zeripath zeripath mentioned this pull request Mar 23, 2022
Merged
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
@zeripath @wxiaoguang
Use the new/choose link for New Issue on project page (go-gitea#19172)
9e2ca46 
Extend issues/new/choose to pass the project id and change New Issue
link on project page to use new/choose

Fix go-gitea#19170

Signed-off-by: Andrew Thornton <[email protected]>
Co-authored-by: wxiaoguang <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.

Allow users to choose issue template from Project view, when clicks New Issue button
4 participants
@zeripath @wxiaoguang @delvh @GiteaBot