Federation: return useful statistic information for nodeinfo

[6543]

TODO:

• UserStatistics
• document new settings
• cache
• ...

[techknowlogick]

@zeripath recently added caching to some of these stats, are you able to leverage the cache as well?

[6543]

@techknowlogick added cache

[wxiaoguang]

The question again, why does Gitea need to provide the accurate count number instead of the estimated count number?

I do not think it's worth introducing new setting options (#19474) to provide the accurate count number which is using slow full table (index) scan. In the other PR: there are options about estimated or not / cache TTL, already doubled to 4 new options, and in future maybe more 6, 8 options if more APIs are introduced ....

Could the problem be simplified to: only provide estimated count number for all users/actions/issues, etc?

From #19474:

I would prefer to avoid introducing new options, and just tell users that these metrics are estimated. The reason is that the accurate count number of action/star/user/etc do not help admin really. If you read a count number 1000 at first time, next minute it may become 1100, there is no really accurate and meaningful count number indeed. So in the end there is no difference between providing an estimated number or an accurate number.

The UI can just tell admin that these numbers are estimated, it should be enough.

[lunny]

What's the aim to expose these statistic information?

[6543]

so services likehttps://the-federation.info/ (https://github.com/thefederationinfo/the-federation.info/issues/149) can discover nodes and make suggestions where to join the "federated gitea network"

[6543]

@wxiaoguang @zeripath to the cache and aproximate counts:

you can not count users aproximate, as orgs are also in the same table.
also a single count query max every 2min should not be a problem at all (see caching)

beside the caching in #19474, I would like to implement it as router middleware later on (not part of this pull atm), so we can transparent say m.Get("...", context.Cache(2min), ....) - so we can speed ups some more apis ;)

[6543]

I do not think it's worth introducing new setting options

I still think we should add this, all federated software I know of has this flag/setting (synapse, diaspora, ...)

[6543]

The UI can just tell admin that these numbers are estimated, it should be enough.

nodeinfo is not for the admin but for the federation ... as per label

[wxiaoguang]

I do not think it's worth introducing new setting options

I still think we should add this, all federated software I know of has this flag/setting (synapse, diaspora, ...)

The new setting options I meant is estimated or not, cache TTL, and doubled to 4 options in another PR.

For this one, ShareUserStatistics does what it should do and seems right.

[6543]

ok, is something else blocking it?

[lunny]

I do not think it's worth introducing new setting options

I still think we should add this, all federated software I know of has this flag/setting (synapse, diaspora, ...)

Maybe we need a doc about federation which information will be exposed.

[6543]

@lunny I think we need a new document section for federation, since this is only one part we should explain & document

should I add it in this pull?

[Gusted]

Federation: return usefull statistic information for nodeinfo

-> Federation: return useful statistic information for nodeinfo