Remove stars when repo goes private

[42wim]

Fixes #18600

[codecov-commenter]

Codecov Report

❗ No coverage uploaded for pull request base (main@3d9c02a). Click here to learn what that means.
The diff coverage is 18.18%.

@@           Coverage Diff           @@
##             main   #19904   +/-   ##
=======================================
  Coverage        ?   47.31%           
=======================================
  Files           ?      960           
  Lines           ?   133686           
  Branches        ?        0           
=======================================
  Hits            ?    63247           
  Misses          ?    62727           
  Partials        ?     7712           

Impacted Files	Coverage Δ
modules/repository/create.go	42.28% <0.00%> (ø)
models/repo/star.go	38.98% <25.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d9c02a...c57c545. Read the comment docs.

[techknowlogick]

Perhaps we should add a UI warning that starts will be removed when made private, as we don't want to repeat: https://twitter.com/httpie/status/1514729922799022083

[lunny]

We need to add this to change list on the popup warning window.

[a1012112796]

In my view, maybe should recheck read permission of each stared users.

[lunny]

In my view, maybe should recheck read permission of each stared users.

But that's a low-performance thing.

[42wim]

We need to add this to change list on the popup warning window.

Which change list do you mean ? on which warning window ?
Afaik nothing shows a popup when updating anything on the basic setings of the repo.
(should we move setting the repo private to the danger zone?)

[silverwind]

We need to add this to change list on the popup warning window.

Which change list do you mean ? on which warning window ? Afaik nothing shows a popup when updating anything on the basic setings of the repo. (should we move setting the repo private to the danger zone?)

I'd just add a tooltip:

<div class="ui checkbox tooltip" data-content="This will remove all stars from this repository">

Of course, it should only show if repo actually has any stars and only when the checkbox is rendered unchecked.

[42wim]

Sure

[lunny]

We need to add this to change list on the popup warning window.

Which change list do you mean ? on which warning window ? Afaik nothing shows a popup when updating anything on the basic setings of the repo. (should we move setting the repo private to the danger zone?)

I mean we need to popup a warning window when submit the button if private property changed. The popup window should list all possible break changes.

[silverwind]

Happy with tooltip alone, anything more is overkill imho

[lunny]

There is already a hint beside the checkbox.

Then another tooltip is also about the effect.

I think we can group the two warning into a popup window and user have a confirm button.

[rempas]

There is already a hint beside the checkbox.

Then another tooltip is also about the effect.

I think we can group the two warning into a popup window and user have a confirm button.

I also think a pop-up is a better idea! Some users may just press it without noticing the tooltip (which is their mistake but still). Don't forget that is something very important and there is no turning back after that. So in my humble opinion, having a pop-up after ticking the box is a better idea.

Batter be safe than sorry!

[6543]

agree - we need to highlight that this is a ireversible change as stuff will get deleted

mv in new issue