Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid new stack context for task list items (#20377) #20378

Closed
wants to merge 3 commits into from

Conversation

Gusted
Copy link
Contributor

@Gusted Gusted commented Jul 15, 2022

  • Backport Avoid new stack context for task list items #20377

    • Avoid creating a new stack context on a task list item, this PR does that by removing the position: relative which causes a new stack context to be created on that element. And thereby solving that popups weren't able to utilize their z-index and weren't able to show properly.

    Before:
    image

    After:
    image

- Backport go-gitea#20377
  - Avoid creating a new stack context on a task list item, this PR does that by removing the `position: relative` which causes a new stack context to be created on that element. And thereby solving that popups weren't able to utilize their z-index and weren't able to show properly.

  Before:
  ![image](https://user-images.githubusercontent.com/25481501/179135078-63805ccc-17bc-4e11-8393-cdb6f1916cdd.png)

  After:
  ![image](https://user-images.githubusercontent.com/25481501/179135105-09996426-85da-40d7-8777-46a16a9413fe.png)
@Gusted Gusted added this to the 1.17.0 milestone Jul 15, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jul 15, 2022
@Gusted Gusted added the pr/wip This PR is not ready for review label Jul 16, 2022
@Gusted Gusted closed this Jul 17, 2022
@Gusted Gusted deleted the backport-20377 branch July 17, 2022 20:09
@6543 6543 removed this from the 1.17.0 milestone Jul 19, 2022
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/need 1 This PR needs approval from one additional maintainer to be merged. pr/wip This PR is not ready for review type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants