Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Downgrade golangci-lint to 1.47.0 #20445

Merged
merged 2 commits into from
Jul 22, 2022
Merged

Downgrade golangci-lint to 1.47.0 #20445

merged 2 commits into from
Jul 22, 2022

Conversation

silverwind
Copy link
Member

This should fix some recently seen linter performance issues.

Ref: golangci/golangci-lint#2997

@silverwind silverwind added dependencies skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Jul 21, 2022
@silverwind
Copy link
Member Author

There is some log spam, but it's definitely faster.

level=warning msg="[linter] revive: the following rules (context-keys-type,errorf,modifies-value-receiver,time-naming,unexported-return,var-declaration) are ignored due to a performance problem (https://github.com/golangci/golangci-lint/issues/2997)"

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 21, 2022
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 21, 2022
@silverwind silverwind changed the title Upgrade golangci-lint to 1.47.2 Downgrade golangci-lint to 1.47.0 Jul 21, 2022
@silverwind
Downgrade golangci-lint to 1.47.0
ddbaf36 
This should fix some recently seen linter performance issues.

Ref: golangci/golangci-lint#2997
@silverwind
Copy link
Member Author

It's now a downgrade, the log spam of 1.47.2 was too much imho.

wxiaoguang
wxiaoguang approved these changes Jul 22, 2022
View reviewed changes
Copy link
Contributor

@wxiaoguang wxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's try it

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 22, 2022
@wxiaoguang wxiaoguang merged commit 339007b into go-gitea:main Jul 22, 2022
@silverwind silverwind deleted the lint1.47.2 branch July 22, 2022 05:27
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jul 25, 2022
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
6779933 
* giteaofficial/main:
  Fix Ruby package parsing by removed unused email field (go-gitea#20470)
  [skip ci] Updated translations via Crowdin
  Add repository condition for issue count (go-gitea#20454)
  Prepend commit message to template content (go-gitea#20429)
  Improve pprof doc (go-gitea#20463)
  Improve code diff highlight, fix incorrect rendered diff result (go-gitea#19958)
  Add Cache-Control header to html and api responses, add no-transform (go-gitea#20432)
  [skip ci] Updated translations via Crowdin
  Allow non-semver packages in the Conan package registry (go-gitea#20412)
  Use body text color in repository files table links (go-gitea#20386)
  Correct code block in installation docs for Snap (go-gitea#20440)
  Downgrade golangci-lint to 1.47.0 (go-gitea#20445)
  Add eslint-plugin-sonarjs (go-gitea#20431)
  Fix: Actor is required to get user repositories (go-gitea#20443)
  Add "X-Gitea-Object-Type" header for GET `/raw/` & `/media/` API (go-gitea#20438)
  Simplify visibility checks (go-gitea#20406)
vsysoev pushed a commit to IntegraSDL/gitea that referenced this pull request Aug 10, 2022
@silverwind @lunny
Downgrade golangci-lint to 1.47.0 (go-gitea#20445)
2321553 
This should fix some recently seen linter performance issues. There is some log spam, but it's definitely faster.

Ref: golangci/golangci-lint#2997

Co-authored-by: Lunny Xiao <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@silverwind @zeripath @wxiaoguang @GiteaBot @lunny