Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebAuthn CredentialID field needs to be increased in size (#20530) #20555

Merged
merged 3 commits into from
Jul 30, 2022
Merged

WebAuthn CredentialID field needs to be increased in size (#20530) #20555

merged 3 commits into from
Jul 30, 2022

Conversation

6543
Copy link
Member

@6543 6543 commented Jul 30, 2022 •
edited
Loading

Backport #20530

@6543 6543 added type/bug issue/critical This issue should be fixed ASAP. If it is a PR, the PR should be merged ASAP labels Jul 30, 2022
@6543 6543 added this to the 1.17.0 milestone Jul 30, 2022
@zeripath @6543
WebAuthn CredentialID field needs to be increased in size (go-gitea#2…
c5a1289 
…0530)

WebAuthn have updated their specification to set the maximum size of the
CredentialID to 1023 bytes. This is somewhat larger than our current
size and therefore we need to migrate.

The PR changes the struct to add CredentialIDBytes and migrates the CredentialID string
to the bytes field before another migration drops the old CredentialID field. Another migration
renames this field back.

Fix go-gitea#20457

Signed-off-by: Andrew Thornton <[email protected]>
@6543 6543 marked this pull request as ready for review July 30, 2022 15:53
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jul 30, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 30, 2022
@6543 6543 merged commit 09f2e1e into go-gitea:release/v1.17 Jul 30, 2022
@6543 6543 deleted the backport_20530 branch July 30, 2022 18:16
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Gusted Gusted Gusted approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
issue/critical This issue should be fixed ASAP. If it is a PR, the PR should be merged ASAP lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.
4 participants
@6543 @zeripath @Gusted @GiteaBot