Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the vscode clone link respect transport protocol #20557

Merged
merged 14 commits into from
Sep 9, 2022
Merged

Make the vscode clone link respect transport protocol #20557

merged 14 commits into from
Sep 9, 2022

Conversation

noerw
Copy link
Member

@noerw noerw commented Jul 30, 2022

Makes the vscode clone link respect the clone URL that's also used for the clone buttons
closes #20554

@noerw noerw added type/enhancement An improvement of existing functionality topic/ui Change the appearance of the Gitea UI labels Jul 30, 2022
@noerw noerw added this to the 1.18.0 milestone Jul 30, 2022
@monim67
Copy link

monim67 commented Jul 30, 2022

Can we get it on 1.17 release?

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 30, 2022
@wxiaoguang
Copy link
Contributor

I think we should wait for #20415 first.

@noerw noerw added the status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR label Jul 31, 2022
@6543 6543 removed the status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR label Jul 31, 2022
@noerw
Copy link
Member Author

noerw commented Aug 1, 2022

@wxiaoguang adjusted to use the new clone button script :)

@monim67
Copy link

monim67 commented Aug 23, 2022

Any update on this?

@monim67
Copy link

monim67 commented Sep 4, 2022

This PR fixes the merge conflicts.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 9, 2022
wxiaoguang
wxiaoguang approved these changes Sep 9, 2022
View reviewed changes
Copy link
Contributor

@wxiaoguang wxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some small changes.

  1. revert the code for document.getElementsByClassName('js-clone-url'), they were there and do not need to be touched IMO.
  2. use js-clone-url-vsc instead of js-clone-url-vs, because Visual Studio is not the same as Visual Studio Code, and the translation already used vsc("repo.clone_in_vsc") abbr before.

templates/repo/clone_script.tmpl Outdated Show resolved Hide resolved
templates/repo/clone_script.tmpl Outdated Show resolved Hide resolved
templates/repo/clone_script.tmpl Outdated Show resolved Hide resolved
templates/repo/home.tmpl Outdated Show resolved Hide resolved
@GiteaBot GiteaBot removed the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Sep 9, 2022
@GiteaBot GiteaBot added the lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. label Sep 9, 2022
@techknowlogick techknowlogick merged commit 86ed47e into go-gitea:main Sep 9, 2022
zjjhot added a commit to zjjhot/gitea that referenced this pull request Sep 9, 2022
@zjjhot
Merge remote-tracking branch 'upstream/main'
6d0fc62 
* upstream/main:
  Make the vscode clone link respect transport protocol (go-gitea#20557)
  Fix typo of issue template name (go-gitea#21117)
  [skip ci] Updated translations via Crowdin
  Fix pagination limit parameter problem (go-gitea#21109)
  Rewrite go license generator in go (go-gitea#21078)
  Allow uppercase ASCII alphabet in PyPI package names (go-gitea#21095)
  Fix various typos (go-gitea#21103)
  Update docs issue-pull-request-templates.zh-cn.md (go-gitea#21030)
  Upgrade the document about how to collect logs for systemd and docker (go-gitea#21101)
monim67 pushed a commit to monim67/gitea that referenced this pull request Sep 9, 2022
@noerw @monim67
Make the vscode clone link respect transport protocol (go-gitea#20557)
a380709
@ghost ghost mentioned this pull request Sep 9, 2022
Merged
wxiaoguang pushed a commit that referenced this pull request Sep 20, 2022
@noerw @monim67
Make the vscode clone link respect transport protocol (#20557) (#21128)
54d4e66 
Backports #20557

Co-authored-by: Norwin <[email protected]>
Co-authored-by: Munim Munna <[email protected]>
@wxiaoguang wxiaoguang mentioned this pull request Sep 21, 2022
Merged
wxiaoguang added a commit that referenced this pull request Sep 21, 2022
@wxiaoguang
Make Clone in VSCode link get updated correctly (#21225)
d9bc688 
Follow #20557, fix #21224

The `clone_script` will update `.js-clone-url` and related elements,
so it should be put after these elements.
@6543 6543 deleted the vscode-ssh branch October 15, 2022 12:53
@6543 6543 added the backport/done All backports for this PR have been created label Oct 15, 2022
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@techknowlogick techknowlogick techknowlogick approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.18.0
Development

Successfully merging this pull request may close these issues.

Clone in VS Code option for SSH
7 participants
@noerw @monim67 @wxiaoguang @techknowlogick @lunny @GiteaBot @6543