Remove debug output when coverage fails #20733
Conversation
silverwind
added
topic/build
|
Debug output was added in c0f5da3 by @zeripath, but I think as it stands now, it's not useful as long as drone truncates it to 5MB. I find no documented way to increase this 5mb limit, I think drone hardcodes it currently, latest reference I find is harness/harness#2456 (comment). |
GiteaBot
added
the
lgtm/need 2
|
If you remove this logging then we have no way of working out why the coverage is failing. Do we understand why coverage keeps failing at present? |
No, but maybe a few re-runs of this will reveal the error without all the debug spam. As is stands, the debug output is useless as long as drone truncates it to 5MB. By the way, what is the point of this coverage task? Is it needed for external tools like CodeCov? Surely those tools can generate coverage stats on their own? |
|
I see that these tasks actually uploads to codecov. Still I wonder the value. I think most contributors ignore code coverage and these codecov reports are generally perceived as spam because the percentages are not stable. I think we should just drop this codecov integration as it introduces unnecessary build failures. Anything that can fail a build randomly should be eliminated, as it just wastes everyone's time 😉. |
When coverage fails, it logs megabytes of debug to stdout, which seems to break the drone ui as well as the log output download in drone, presumably because of the size. I think with removal of this print, we should still see any errors created by gocovmerge.go, but a few CI runs may be necessary to get it to fail again.
GiteaBot
added
lgtm/need 1
GiteaBot
added
lgtm/done
* giteaofficial/main: Remove follow from commits by file (go-gitea#20765) [skip ci] Updated translations via Crowdin Fix `make watch` for generated files (go-gitea#20794) Add missing translation for queue flush workers (go-gitea#20791) Update zh-cn translation for Installation from source (go-gitea#20772) Improve comment header for Mobile (go-gitea#20781) Add myself to MAINTAINERS (go-gitea#20786) [skip ci] Updated licenses and gitignores Preserve unix socket file (go-gitea#20499) Switch Unicode Escaping to a VSCode-like system (go-gitea#19990) Fix git.Init for doctor sub-command (go-gitea#20782) Remove the translation key website by PR go-gitea#20777 (go-gitea#20779) Move the official website link at the footer of gitea (go-gitea#20777) Remove useless JS operation for relative time tooltips (go-gitea#20756) Remove debug output when coverage fails (go-gitea#20733) Slightly reduce exclamation icon size (go-gitea#20753)
* Remove debug output when coverage fails When coverage fails, it logs megabytes of debug to stdout, which seems to break the drone ui as well as the log output download in drone, presumably because of the size. I think with removal of this print, we should still see any errors created by gocovmerge.go, but a few CI runs may be necessary to get it to fail again. * Update Makefile * restart ci * restart ci * restart ci * restart ci Co-authored-by: techknowlogick <[email protected]>
When
make coveragefails, it logs megabytes of debug to stdout, which seems to break the drone ui as well as the log output download in drone, presumably because drone limits downloadable log size to 5MB. I think with removal of this print, we should still see any errors that gocovmerge.go logs to stderr, but a few CI runs may be necessary to get it to fail again.Example failures:
https://drone.gitea.io/go-gitea/gitea/58933/2/18
https://drone.gitea.io/go-gitea/gitea/58928/2/17