Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SAML SP status to Feature Comparison docs #20743

Merged
merged 5 commits into from
Aug 11, 2022
Merged

Conversation

Mortein
Copy link
Contributor

@Mortein Mortein commented Aug 9, 2022

Add current status of SAML 2.0 Service Provider (SP) to the feature comparison pages. Included issue links for both Gitea (#5512) and Gogs (gogs/gogs#1221), as corporate users will likely be interested in the status of both.

I had a look at CONTRIBUTING.md, which mentioned translations were in Crowdin, but I'm assuming this does not include the documentation.

Add current SAML 2.0 Service Provider (SP) status. RhodeCode EE supports SAML, CE does not.

Included issue links for both Gitea and Gogs, as corporate users will likely be interested in the status of both.
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Aug 9, 2022
@Gusted Gusted added type/docs This PR mainly updates/creates documentation skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Aug 9, 2022
@wxiaoguang
Copy link
Contributor

IMO, "not mentioning it" already means that Gitea doesn't have the feature.

There are a lot of features that Gitea doesn't have, it's not worth to put a lot of cross-marks(✘) in the document.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 10, 2022
@lafriks
Copy link
Member

lafriks commented Aug 10, 2022

@wxiaoguang we try to make that comparison to not be selective just to features we support. Even GitLab links from their docs to our comparison page 😉

@6543
Copy link
Member

6543 commented Aug 11, 2022

.

@6543 6543 merged commit 2b4d43d into go-gitea:main Aug 11, 2022
@Mortein Mortein deleted the patch-1 branch August 11, 2022 19:36
vsysoev pushed a commit to IntegraSDL/gitea that referenced this pull request Aug 28, 2022
* Add SAML SP integration

Add current SAML 2.0 Service Provider (SP) status. RhodeCode EE supports SAML, CE does not.

Included issue links for both Gitea and Gogs, as corporate users will likely be interested in the status of both.

* Add SAML SP status to comparison for other translations

Co-authored-by: Lauris BH <[email protected]>
Co-authored-by: Lunny Xiao <[email protected]>
Co-authored-by: wxiaoguang <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/docs This PR mainly updates/creates documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants