Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more checks in migration code #21011

Merged
merged 19 commits into from
Sep 4, 2022
Merged

Add more checks in migration code #21011

merged 19 commits into from
Sep 4, 2022

Commits on Aug 31, 2022

  1. Add more checks in migration code 

    When migrating add several more important sanity checks:

* SHAs must be SHAs
* Refs must be valid Refs
* URLs must be reasonable

Signed-off-by: Andrew Thornton <[email protected]>
    @zeripath
    zeripath committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    f971a3b View commit details
    Browse the repository at this point in the history

  2. oops 

    Signed-off-by: Andrew Thornton <[email protected]>
    @zeripath
    zeripath committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    657d54d View commit details
    Browse the repository at this point in the history

  3. oops 2 

    Signed-off-by: Andrew Thornton <[email protected]>
    @zeripath
    zeripath committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    6305ad2 View commit details
    Browse the repository at this point in the history

  4. only set head.SHA when the SHA is available 

    Signed-off-by: Andrew Thornton <[email protected]>
    @zeripath
    zeripath committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    992ba59 View commit details
    Browse the repository at this point in the history

  5. ensure test-backend passes 

    Signed-off-by: Andrew Thornton <[email protected]>
    @zeripath
    zeripath committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    4ecf851 View commit details
    Browse the repository at this point in the history

  6. fix dump 

    Signed-off-by: Andrew Thornton <[email protected]>
    @zeripath
    zeripath committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    fddbb29 View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2022

  1. Merge branch 'main' into migration-checks

    @zeripath
    zeripath authored Sep 2, 2022
    Configuration menu
    Copy the full SHA
    0ca166c View commit details
    Browse the repository at this point in the history

  2. Update modules/validation/binding.go 

    Co-authored-by: techknowlogick <[email protected]>
    @zeripath @techknowlogick
    zeripath and techknowlogick authored Sep 2, 2022
    Configuration menu
    Copy the full SHA
    6995b11 View commit details
    Browse the repository at this point in the history

  3. Update services/migrations/dump.go 

    Co-authored-by: techknowlogick <[email protected]>
    @zeripath @techknowlogick
    zeripath and techknowlogick authored Sep 2, 2022
    Configuration menu
    Copy the full SHA
    b0df6d0 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into migration-checks

    @zeripath
    zeripath authored Sep 2, 2022
    Configuration menu
    Copy the full SHA
    cf5a1d2 View commit details
    Browse the repository at this point in the history

  5. Add check against external->local 

    Signed-off-by: Andrew Thornton <[email protected]>
    @zeripath
    zeripath committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    9dddb96 View commit details
    Browse the repository at this point in the history

  6. use common function for testing against baseurl 

    Signed-off-by: Andrew Thornton <[email protected]>
    @zeripath
    zeripath committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    1d44aca View commit details
    Browse the repository at this point in the history

  7. add check to restore 

    Signed-off-by: Andrew Thornton <[email protected]>
    @zeripath
    zeripath committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    4b31472 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2022

  1. oops 

    Signed-off-by: Andrew Thornton <[email protected]>
    @zeripath
    zeripath committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    63715dd View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into migration-checks

    @zeripath
    zeripath authored Sep 3, 2022
    Configuration menu
    Copy the full SHA
    f1de1b2 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2022

  1. as per review 

    Signed-off-by: Andrew Thornton <[email protected]>
    @zeripath
    zeripath committed Sep 4, 2022
    Configuration menu
    Copy the full SHA
    e32d0a3 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/main' into migration-checks

    @zeripath
    zeripath committed Sep 4, 2022
    Configuration menu
    Copy the full SHA
    38353f3 View commit details
    Browse the repository at this point in the history

  3. placate the linter 

    Signed-off-by: Andrew Thornton <[email protected]>
    @zeripath
    zeripath committed Sep 4, 2022
    Configuration menu
    Copy the full SHA
    be367a3 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into migration-checks

    @zeripath
    zeripath authored Sep 4, 2022
    Configuration menu
    Copy the full SHA
    e494fc5 View commit details
    Browse the repository at this point in the history