Add support for the Friendly Forge Format (F3) #21081

earl-warren · 2022-09-06T05:03:00Z

This pull request is a mirror of a corresponding pull request on gitea.com, please go there to discuss and comment.

depends on:

https://lab.forgefriends.org/friendlyforgeformat/gof3/-/issues/21

Continuation of this previous pull request

earl-warren · 2022-09-06T06:44:30Z

How can it be that lint on windows reports an error and lint on GNU/Linux does not?

silverwind · 2022-09-06T09:41:08Z

How can it be that lint on windows reports an error and lint on GNU/Linux does not?

I think the only logical reason would be presence of //go:build tags that run only on Windows, but that doesn't seem to be the case here. Might just restart and see if it goes away.

earl-warren · 2022-09-07T00:25:51Z

How can it be that lint on windows reports an error and lint on GNU/Linux does not?

I think the only logical reason would be presence of //go:build tags that run only on Windows, but that doesn't seem to be the case here. Might just restart and see if it goes away.

But there are no //go:build tags in this PR. Is there a way to re-launch the CI and verify this is not a false negative?

silverwind · 2022-09-07T11:19:59Z

Just push an empty commit to restart CI:

git commit --allow-empty -m 'restart ci'

services/f3/driver/driver.go

delvh · 2022-09-09T07:45:36Z

We know. #21108

silverwind · 2022-09-21T19:59:03Z

Side note:

This pull request is a mirror of a corresponding pull request on gitea.com, please go there to discuss and comment.

gitea core development takes place on GitHub, so it should be reviewed/discussed here :)

services/f3/driver/pull_request.go

earl-warren · 2022-09-23T07:43:33Z

Side note:

This pull request is a mirror of a corresponding pull request on gitea.com, please go there to discuss and comment.

gitea core development takes place on GitHub, so it should be reviewed/discussed here :)

I did not want to force people to agree to the GitHub terms of service to participate in this particular pull request. Moving the discussion to gitea.com is more inclusive in a way that is not disruptive to the Gitea development process.

earl-warren · 2022-09-24T07:34:54Z

Side note:

This pull request is a mirror of a corresponding pull request on gitea.com, please go there to discuss and comment.

gitea core development takes place on GitHub, so it should be reviewed/discussed here :)

I did not want to force people to agree to the GitHub terms of service to participate in this particular pull request. Moving the discussion to gitea.com is more inclusive in a way that is not disruptive to the Gitea development process.

I commented further on the issue you opened that is related to this topic.

Gusted · 2022-09-24T15:27:44Z

Just to mention this again, a valid point was raised on the previous PR for F3. I would like to state again that Loïc and the other contributors will change the license to MIT when this PR is approved to be merged.

user, topic, project, label, milestone, repository, pull_request, release, asset, comment, reaction, review providers Signed-off-by: Earl Warren <[email protected]>

6543 · 2022-10-16T17:24:50Z

@earl-warren could you add me to your fork as contrib (write access)? so i can update that pull ... also if you would not force-push I would aprechiate!

6543 · 2022-10-16T17:41:07Z

blocked by https://lab.forgefriends.org/friendlyforgeformat/gof3/-/issues/21

6543 · 2022-10-16T17:56:51Z

modules/setting/f3.go

+)
+
+func newF3Service() {
+	if err := Cfg.Section("F3").MapTo(&F3); err != nil {


all other sections are lowercase

Suggested change

if err := Cfg.Section("F3").MapTo(&F3); err != nil {

if err := Cfg.Section("f3").MapTo(&F3); err != nil {

6543 · 2022-10-16T17:57:06Z

custom/conf/app.example.ini

@@ -2294,6 +2294,15 @@ ROUTER = console
 ;; If a domain is allowed by ALLOWED_DOMAINS, this option will be ignored.
 ;ALLOW_LOCALNETWORKS = false

+;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
+;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
+;[F3]


Suggested change

;[F3]

;[f3]

6543 · 2022-10-24T13:54:34Z

please update branch & update f3 dep

earl-warren marked this pull request as draft September 6, 2022 05:03

earl-warren mentioned this pull request Sep 6, 2022

Plans for Gitea v1.18 #20022

Closed

earl-warren changed the title ~~F3: initial support with user & project providers~~ Add support for the Friendly Forge Format (F3) Sep 6, 2022

silentcodeg assigned earl-warren Sep 6, 2022

silentcodeg added type/feature Completely new functionality. Can only be merged if feature freeze is not active. topic/repo-migration Migrate repos from other platforms to Gitea, or from Gitea to them labels Sep 6, 2022

GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 6, 2022

earl-warren force-pushed the gitea-feature-f3 branch from df1132b to 10ef80c Compare September 7, 2022 23:37

This comment was marked as resolved.

Sign in to view

earl-warren force-pushed the gitea-feature-f3 branch 2 times, most recently from be0af5f to 17e66df Compare September 8, 2022 07:19

6543 reviewed Sep 8, 2022

View reviewed changes

services/f3/driver/driver.go Outdated Show resolved Hide resolved

earl-warren force-pushed the gitea-feature-f3 branch 2 times, most recently from f8cd0a9 to e4ce565 Compare September 9, 2022 00:43

This comment was marked as resolved.

Sign in to view

earl-warren force-pushed the gitea-feature-f3 branch from e4ce565 to 8b0f64f Compare September 10, 2022 00:46

This comment was marked as resolved.

Sign in to view

earl-warren force-pushed the gitea-feature-f3 branch 7 times, most recently from ae00aee to c4a5a4d Compare September 16, 2022 15:22

earl-warren force-pushed the gitea-feature-f3 branch from c4a5a4d to 9c1e5b7 Compare September 18, 2022 15:27

earl-warren marked this pull request as draft September 21, 2022 15:23

silverwind reviewed Sep 21, 2022

View reviewed changes

services/f3/driver/pull_request.go Outdated Show resolved Hide resolved

earl-warren force-pushed the gitea-feature-f3 branch 2 times, most recently from 0020f29 to e764d44 Compare September 24, 2022 07:24

earl-warren force-pushed the gitea-feature-f3 branch from e764d44 to e3a4393 Compare September 24, 2022 10:57

earl-warren marked this pull request as ready for review September 24, 2022 11:49

earl-warren force-pushed the gitea-feature-f3 branch from e3a4393 to 7e972c8 Compare September 24, 2022 11:49

earl-warren force-pushed the gitea-feature-f3 branch 6 times, most recently from 7c09cb6 to 251a962 Compare October 2, 2022 15:58

F3: Gitea driver and CLI

61302eb

user, topic, project, label, milestone, repository, pull_request, release, asset, comment, reaction, review providers Signed-off-by: Earl Warren <[email protected]>

earl-warren force-pushed the gitea-feature-f3 branch from 251a962 to 61302eb Compare October 3, 2022 11:51

6543 added this to the 1.18.0 milestone Oct 16, 2022

6543 reviewed Oct 16, 2022

View reviewed changes

lunny modified the milestones: 1.18.0, 1.19.0 Oct 26, 2022

earl-warren closed this Nov 26, 2022

lunny removed this from the 1.19.0 milestone Feb 22, 2023

go-gitea locked and limited conversation to collaborators May 3, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for the Friendly Forge Format (F3) #21081

Add support for the Friendly Forge Format (F3) #21081

earl-warren commented Sep 6, 2022 •

edited by 6543

Loading

earl-warren commented Sep 6, 2022

silverwind commented Sep 6, 2022 •

edited

Loading

earl-warren commented Sep 7, 2022 •

edited

Loading

silverwind commented Sep 7, 2022

This comment was marked as resolved.

This comment was marked as resolved.

delvh commented Sep 9, 2022

This comment was marked as resolved.

silverwind commented Sep 21, 2022

earl-warren commented Sep 23, 2022 •

edited

Loading

earl-warren commented Sep 24, 2022

Gusted commented Sep 24, 2022

6543 commented Oct 16, 2022 •

edited

Loading

6543 commented Oct 16, 2022

6543 Oct 16, 2022

6543 Oct 16, 2022

6543 commented Oct 24, 2022

	if err := Cfg.Section("F3").MapTo(&F3); err != nil {
	if err := Cfg.Section("f3").MapTo(&F3); err != nil {

Add support for the Friendly Forge Format (F3) #21081

Add support for the Friendly Forge Format (F3) #21081

Conversation

earl-warren commented Sep 6, 2022 • edited by 6543 Loading

earl-warren commented Sep 6, 2022

silverwind commented Sep 6, 2022 • edited Loading

earl-warren commented Sep 7, 2022 • edited Loading

silverwind commented Sep 7, 2022

This comment was marked as resolved.

This comment was marked as resolved.

delvh commented Sep 9, 2022

This comment was marked as resolved.

silverwind commented Sep 21, 2022

earl-warren commented Sep 23, 2022 • edited Loading

earl-warren commented Sep 24, 2022

Gusted commented Sep 24, 2022

6543 commented Oct 16, 2022 • edited Loading

6543 commented Oct 16, 2022

6543 Oct 16, 2022

Choose a reason for hiding this comment

6543 Oct 16, 2022

Choose a reason for hiding this comment

6543 commented Oct 24, 2022

earl-warren commented Sep 6, 2022 •

edited by 6543

Loading

silverwind commented Sep 6, 2022 •

edited

Loading

earl-warren commented Sep 7, 2022 •

edited

Loading

earl-warren commented Sep 23, 2022 •

edited

Loading

6543 commented Oct 16, 2022 •

edited

Loading