Fixed some small typos and corrected a filepath in the documentation #21322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delvh
approved these changes
Oct 3, 2022
| @@ -67,7 +67,7 @@ Some actions should allow for rollback when database record insertion/update/del | |||
| So services must be allowed to create a database transaction. Here is some example, | |||
|
|
|||
| ```go | |||
| // servcies/repository/repo.go | |||
| // services/repository/repository.go | |||
| func CreateXXXX() error {\ | |||
| ctx, committer, err := db.TxContext() | |||
There was a problem hiding this comment.
This code block can now be updated to use db.WithTx(…)
Should this be done in this PR as well?
GiteaBot
added
the
lgtm/need 1
|
i can make the change if you think it's appropriate
… @delvh approved this pull request.
> @@ -67,7 +67,7 @@ Some actions should allow for rollback when database record insertion/update/del
So services must be allowed to create a database transaction. Here is some example,
```go
-// servcies/repository/repo.go
+// services/repository/repository.go
func CreateXXXX() error {\
ctx, committer, err := db.TxContext()
This code block can now be updated to use `db.WithTx(…)`
Should this be done in this PR as well.
--
Reply to this email directly or view it on GitHub:
#21322 (review)
You are receiving this because you authored the thread.
Message ID: ***@***.***>
|
wxiaoguang
approved these changes
Oct 7, 2022
GiteaBot
added
lgtm/done
wxiaoguang
approved these changes
Oct 7, 2022
zeripath
changed the title
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Oct 8, 2022
* upstream/main: (34 commits) Fix formatted link for PR review notifications to matrix (go-gitea#21319) Show private data in feeds (go-gitea#21369) Add nicer error handling on template compile errors (go-gitea#21350) Fix some typos and update db transaction demo in backend guideline (go-gitea#21322) Refactor parseTreeEntries, speed up tree list (go-gitea#21368) Add GET and DELETE endpoints for Docker blob uploads (go-gitea#21367) Make external issue tracker regexp configurable via API (go-gitea#21338) Add new CSS variables --color-accent and --color-small-accent (go-gitea#21305) Set SemverCompatible to false for Conan packages (go-gitea#21275) Parse OAuth Authorization header when request omits client secret (go-gitea#21351) Disable Firefox E2E tests (go-gitea#21363) Add redirect of /upgrade/ to /upgrade-from-gitea/ on docs site (go-gitea#21330) Update to go-enry v2.8.3 (go-gitea#21360) Update go to 1.19 (go-gitea#21361) SessionUser protection against nil pointer dereference (go-gitea#21358) Fix and improve incorrect error messages (go-gitea#21342) Fix default theme-auto selector when nologin (go-gitea#21346) Add `stat` to `ToCommit` function for speed (go-gitea#21337) Fix typo in API comment document (go-gitea#21347) Update comment about repository.DISABLED_REPO_UNITS in app.example.ini (go-gitea#21343) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.