Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

npm package registry support for bin #21372

Merged
merged 4 commits into from
Oct 8, 2022
Merged

npm package registry support for bin #21372

merged 4 commits into from
Oct 8, 2022

Commits on Oct 7, 2022

  1. npm package registry support for bin 

    npm package.json supports binary packaging:
https://docs.npmjs.com/cli/v8/configuring-npm/package-json#bin

the npm registry documents that the binary references will be attached
to the abbreviated version object:
https://github.com/npm/registry/blob/master/docs/responses/package-metadata.md#abbreviated-version-object

unfortunately their api documentation leaves this out:
https://github.com/npm/registry/blob/master/docs/responses/package-metadata.md#abbreviated-version-objectdoc

which is likely to be the reason this was left out in gitea's initial
implementation

this response is critical for npm to install the binary in the `.bin`
folder so as to be included on the users default bin path, resulting in
immediate access to any binaries provied by the package

Signed-off-by: eleith <[email protected]>
    eleith committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    ac0894a View commit details
    Browse the repository at this point in the history

  2. use more realistic binary path 

    Co-authored-by: silverwind <[email protected]>
    @eleith @silverwind
    eleith and silverwind authored Oct 7, 2022
    Configuration menu
    Copy the full SHA
    f290ddf View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2022

  1. Merge branch 'main' into eleith-npm-versions-bin

    @wxiaoguang
    wxiaoguang authored Oct 8, 2022
    Configuration menu
    Copy the full SHA
    7b0b72d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into eleith-npm-versions-bin

    @wxiaoguang
    wxiaoguang authored Oct 8, 2022
    Configuration menu
    Copy the full SHA
    e7d3e54 View commit details
    Browse the repository at this point in the history