Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sanitize and Escape refs in git backend (#21464) #21463

Merged
merged 14 commits into from
Oct 15, 2022
Merged

Sanitize and Escape refs in git backend (#21464) #21463

merged 14 commits into from
Oct 15, 2022

Conversation

6543
Copy link
Member

@6543 6543 commented Oct 14, 2022 •
edited by wxiaoguang
Loading

Backport #21464 and #21465

@6543 6543 added the type/bug label Oct 14, 2022
@6543 6543 added this to the 1.17.3 milestone Oct 14, 2022
6543 added a commit to 6543-forks/gitea that referenced this pull request Oct 15, 2022
@6543
improve code quality (go-gitea#21462) (go-gitea#21463)
f1830e2 
Backport go-gitea#21462
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Oct 15, 2022
6543
6543 commented Oct 15, 2022
View reviewed changes
modules/git/git.go Outdated Show resolved Hide resolved
@wxiaoguang wxiaoguang changed the title improve code quality (#21462) improve code quality (#21464) Oct 15, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 15, 2022
delvh
delvh approved these changes Oct 15, 2022
View reviewed changes
modules/gitgraph/graph.go Show resolved Hide resolved
@6543 6543 merged commit cd48a00 into go-gitea:release/v1.17 Oct 15, 2022
@6543 6543 deleted the some-nit_17 branch October 15, 2022 12:24
@6543 6543 changed the title improve code quality (#21464) Sanitize and Escape refs in git backend (#21464) Oct 15, 2022
@6543 6543 added the topic/security Something leaks user information or is otherwise vulnerable. Should be fixed! label Oct 15, 2022
@GoVulnBot GoVulnBot mentioned this pull request Oct 16, 2022
Closed
tyroneyeh pushed a commit to tyroneyeh/gitea that referenced this pull request Oct 24, 2022
@6543 @wxiaoguang @tyroneyeh
improve code quality (go-gitea#21464) (go-gitea#21463)
8cb55c1 
Backport go-gitea#21464 and go-gitea#21465

Co-authored-by: wxiaoguang <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@delvh delvh delvh approved these changes

@noerw noerw noerw approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/security Something leaks user information or is otherwise vulnerable. Should be fixed! type/bug
Projects
None yet
Milestone
1.17.3
Development

Successfully merging this pull request may close these issues.
6 participants
@6543 @lunny @wxiaoguang @noerw @delvh @GiteaBot