Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix read system configuration bug when installing #21489

Merged
merged 5 commits into from
Oct 18, 2022
Merged

Fix read system configuration bug when installing #21489

merged 5 commits into from
Oct 18, 2022

Conversation

lunny
Copy link
Member

@lunny lunny commented Oct 17, 2022

@lunny lunny added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Oct 17, 2022
@yardenshoham
Copy link
Member

Still happening

        /home/gitpod/go/src/runtime/panic.go:260 (0x459475)
                panicmem: panic(memoryError)
        /home/gitpod/go/src/runtime/signal_unix.go:835 (0x459445)
                sigpanic: panicmem()
        /workspace/gitea/models/db/context.go:78 (0xb9ca65)
                GetEngine: enginedInterface := ctx.Value(enginedContextKey)
        /workspace/gitea/models/system/setting.go:96 (0xcaa93e)
                GetSettings: if err := db.GetEngine(db.DefaultContext).
        /workspace/gitea/models/system/setting.go:80 (0xcaa765)
                GetSetting: v, err := GetSettings([]string{key})
        /workspace/gitea/models/system/setting.go:147 (0xcab090)
                SetSettingNoVersion: s, err := GetSetting(key)
        /workspace/gitea/routers/install/install.go:446 (0x207260f)
                SubmitInstall: if err := system_model.SetSettingNoVersion(system_model.KeyPictureDisableGravatar, strconv.FormatBool(form.DisableGravatar)); err != nil {
        /workspace/gitea/modules/web/wrap_convert.go:47 (0x1db4f13)
                convertHandler.func3: t(ctx)
        /workspace/gitea/modules/web/wrap.go:41 (0x1db33e4)
                wrapInternal.func1: done, deferrable := handler(resp, req, others...)
        /home/gitpod/go/src/net/http/server.go:2109 (0x94f18e)
                HandlerFunc.ServeHTTP: f(w, r)
        /workspace/go/pkg/mod/github.com/go-chi/chi/[email protected]/mux.go:442 (0x19b1dd5)
                (*Mux).routeHTTP: h.ServeHTTP(w, r)
        /home/gitpod/go/src/net/http/server.go:2109 (0x94f18e)
                HandlerFunc.ServeHTTP: f(w, r)
        /workspace/gitea/routers/install/install.go:89 (0x206f9ea)
                Init.func1.1: next.ServeHTTP(resp, ctx.Req)
        /home/gitpod/go/src/net/http/server.go:2109 (0x94f18e)
                HandlerFunc.ServeHTTP: f(w, r)
        /workspace/gitea/routers/install/routes.go:80 (0x2074e71)
                installRecovery.func1.1: next.ServeHTTP(w, req)
        /home/gitpod/go/src/net/http/server.go:2109 (0x94f18e)
                HandlerFunc.ServeHTTP: f(w, r)
        /workspace/go/pkg/mod/gitea.com/go-chi/[email protected]/session.go:257 (0x11a77aa)
                Sessioner.func1.1: next.ServeHTTP(w, req)
        /home/gitpod/go/src/net/http/server.go:2109 (0x94f18e)
                HandlerFunc.ServeHTTP: f(w, r)
        /workspace/gitea/modules/web/wrap.go:110 (0x1db41e8)
                WrapWithPrefix.func1.1: next.ServeHTTP(resp, req)
        /home/gitpod/go/src/net/http/server.go:2109 (0x94f18e)
                HandlerFunc.ServeHTTP: f(w, r)
        /workspace/gitea/routers/common/middleware.go:79 (0x1e7a4e2)
                Middlewares.func2.1: next.ServeHTTP(resp, req)
        /home/gitpod/go/src/net/http/server.go:2109 (0x94f18e)
                HandlerFunc.ServeHTTP: f(w, r)
        /workspace/gitea/modules/web/routing/logger_manager.go:123 (0x1daf0f3)
                (*requestRecordsManager).handler.func1: next.ServeHTTP(w, req)
        /home/gitpod/go/src/net/http/server.go:2109 (0x94f18e)
                HandlerFunc.ServeHTTP: f(w, r)
        /workspace/go/pkg/mod/github.com/go-chi/chi/[email protected]/middleware/strip.go:30 (0x1e77d78)
                StripSlashes.func1: next.ServeHTTP(w, r)
        /home/gitpod/go/src/net/http/server.go:2109 (0x94f18e)
                HandlerFunc.ServeHTTP: f(w, r)
        /workspace/go/pkg/mod/github.com/chi-middleware/[email protected]/middleware.go:37 (0x1e74516)
                ForwardedHeaders.func1.1: h.ServeHTTP(w, r)
        /home/gitpod/go/src/net/http/server.go:2109 (0x94f18e)
                HandlerFunc.ServeHTTP: f(w, r)
        /workspace/gitea/routers/common/middleware.go:32 (0x1e7a331)
                Middlewares.func1.1: next.ServeHTTP(context.NewResponse(resp), req.WithContext(ctx))
        /home/gitpod/go/src/net/http/server.go:2109 (0x94f18e)
                HandlerFunc.ServeHTTP: f(w, r)
        /workspace/go/pkg/mod/github.com/go-chi/chi/[email protected]/mux.go:88 (0x19afb4f)
                (*Mux).ServeHTTP: mx.handler.ServeHTTP(w, r)
        /workspace/gitea/modules/web/route.go:200 (0x1db280d)
                (*Route).ServeHTTP: r.R.ServeHTTP(w, req)
        /home/gitpod/go/src/net/http/server.go:2947 (0x95258b)
                serverHandler.ServeHTTP: handler.ServeHTTP(rw, req)
        /home/gitpod/go/src/net/http/server.go:1991 (0x94dc66)
                (*conn).serve: serverHandler{c.server}.ServeHTTP(w, w.req)
        /home/gitpod/go/src/runtime/asm_amd64.s:1594 (0x477140)
                goexit: BYTE    $0x90   // NOP

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 17, 2022
@yardenshoham
Copy link
Member

@yardenshoham
Copy link
Member

LGTM

@yardenshoham yardenshoham mentioned this pull request Oct 17, 2022
Open
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 17, 2022
@6543 6543 added this to the 1.18.0 milestone Oct 17, 2022
@6543 6543 added the issue/regression Issue needs no code to be fixed, only a description on how to fix it yourself label Oct 17, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 17, 2022
@lunny
Copy link
Member Author

lunny commented Oct 18, 2022

make L-G-T-M work

@lunny lunny merged commit f0182d8 into go-gitea:main Oct 18, 2022
@lunny lunny deleted the lunny/fix_install_system_config branch October 18, 2022 15:17
@lunny lunny mentioned this pull request Oct 18, 2022
Closed
zjjhot added a commit to zjjhot/gitea that referenced this pull request Oct 19, 2022
@zjjhot
Merge remote-tracking branch 'upstream/main'
ffaded3 
* upstream/main:
  [skip ci] Updated translations via Crowdin
  Remove unnecessary misspell ignore pattern (go-gitea#21475)
  Fix read system configuration bug when installing (go-gitea#21489)
  Fix viewing user subscriptions (go-gitea#21482)
  Make every not exist error unwrappable to a fs.ErrNotExist (go-gitea#20891)
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@6543 6543 6543 approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
issue/regression Issue needs no code to be fixed, only a description on how to fix it yourself lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.18.0
Development

Successfully merging this pull request may close these issues.
5 participants
@lunny @yardenshoham @6543 @delvh @GiteaBot