fix install 500 error #21497
Closed
fix install 500 error #21497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- can't get specific settings from database before install becaucse of no database - should not ``db.UnsetDefaultEngine()`` in ``SubmitInstall`` because it will be used soon. Signed-off-by: a1012112796 <[email protected]>
a1012112796
commented
Oct 18, 2022
| @@ -385,7 +385,6 @@ func SubmitInstall(ctx *context.Context) { | |||
| ctx.RenderWithErr(ctx.Tr("install.invalid_db_setting", err), tplInstall, &form) | |||
| return | |||
| } | |||
| db.UnsetDefaultEngine() | |||
There was a problem hiding this comment.
woder why unset? is it necessary? how about move it to line 583 (before srv.Shutdown() ). thanks
GiteaBot
added
the
lgtm/need 2
a1012112796
added
type/bug
skip-changelog
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
can't get specific settings from database before
install becaucse of no database
should not
db.UnsetDefaultEngine()inSubmitInstallbecause it will be used soon.
related with: Add system setting table with cache and also add cache supports for user setting #18058