Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Do not send notifications for draft releases (#21451)" #21594

Merged
merged 1 commit into from
Oct 25, 2022

Conversation

techknowlogick
Copy link
Member

@techknowlogick techknowlogick commented Oct 25, 2022

This reverts commit a37e8b2 / #21451

Temporarily revert this PR to be able to continue discussion, and potentially get it into 1.19.0

@techknowlogick techknowlogick added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Oct 25, 2022
@techknowlogick techknowlogick added this to the 1.18.0 milestone Oct 25, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Oct 25, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 25, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #21594 (61b9772) into main (5c2089a) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main   #21594      +/-   ##
==========================================
+ Coverage   48.11%   48.13%   +0.01%     
==========================================
  Files        1032     1032              
  Lines      140221   140221              
==========================================
+ Hits        67473    67492      +19     
+ Misses      64658    64637      -21     
- Partials     8090     8092       +2     
Impacted Files Coverage Δ
services/release/release.go 46.09% <100.00%> (ø)
modules/git/repo_base_nogogit.go 71.69% <0.00%> (-3.78%) ⬇️
modules/git/blame.go 71.91% <0.00%> (-3.38%) ⬇️
modules/git/utils.go 66.29% <0.00%> (-3.38%) ⬇️
modules/queue/queue_channel.go 78.70% <0.00%> (-1.86%) ⬇️
modules/queue/workerpool.go 55.95% <0.00%> (-0.78%) ⬇️
services/pull/pull.go 41.08% <0.00%> (-0.63%) ⬇️
routers/web/auth/oauth.go 27.23% <0.00%> (-0.44%) ⬇️
models/issues/comment.go 50.21% <0.00%> (-0.11%) ⬇️
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@6543 6543 merged commit 3f7cab4 into go-gitea:main Oct 25, 2022
@techknowlogick techknowlogick deleted the revert-21451 branch October 25, 2022 22:05
zjjhot added a commit to zjjhot/gitea that referenced this pull request Oct 26, 2022
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Revert "Do not send notifications for draft releases (go-gitea#21451)" (go-gitea#21594)
  Change `commits-table` column width (go-gitea#21564)
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants