Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust gitea doctor --run storages to check all storage types #21785

Merged
merged 7 commits into from
Nov 15, 2022

Conversation

zeripath
Copy link
Contributor

The doctor check storages currently only checks the attachment storage. This PR adds some basic garbage collection functionality for the other types of storage.

Signed-off-by: Andrew Thornton [email protected]

The doctor check `storages` currently only checks the attachment storage. This PR adds some
basic garbage collection functionality for the other types of storage.

Signed-off-by: Andrew Thornton <[email protected]>
@zeripath zeripath added type/bug type/enhancement An improvement of existing functionality labels Nov 12, 2022
@zeripath zeripath added this to the 1.19.0 milestone Nov 12, 2022
@zeripath
Copy link
Contributor Author

This is part of implementing garbage collection for LFS in #7045

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 12, 2022
models/repo/archiver.go Outdated Show resolved Hide resolved
modules/util/string.go Outdated Show resolved Hide resolved
models/repo/avatar.go Outdated Show resolved Hide resolved
models/user/avatar.go Outdated Show resolved Hide resolved
modules/doctor/storage.go Outdated Show resolved Hide resolved
modules/doctor/storage.go Outdated Show resolved Hide resolved
modules/doctor/storage.go Show resolved Hide resolved
modules/doctor/storage.go Outdated Show resolved Hide resolved
modules/doctor/storage.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 13, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 13, 2022
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 15, 2022
@lunny
Copy link
Member

lunny commented Nov 15, 2022

Also related with #20514

@lunny lunny merged commit c772934 into go-gitea:main Nov 15, 2022
@lunny lunny removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 15, 2022
@zeripath zeripath deleted the improve-storage-doctor-command branch November 15, 2022 22:39
zjjhot added a commit to zjjhot/gitea that referenced this pull request Nov 16, 2022
* giteaofficial/main:
  Added space between avatar and username (go-gitea#21825)
  Skip GitHub migration tests if the API token is undefined (go-gitea#21824)
  Add `updated_at` field to PullReview API object (go-gitea#21812)
  Adjust gitea doctor --run storages to check all storage types (go-gitea#21785)
  Remove `href="javascript:;"` in "save topics (Done)" button (go-gitea#21813)
  Improve pull/ push mirror documentation (especially for GitHub) (go-gitea#21801)
fsologureng pushed a commit to fsologureng/gitea that referenced this pull request Nov 22, 2022
…ea#21785)

The doctor check `storages` currently only checks the attachment
storage. This PR adds some basic garbage collection functionality for
the other types of storage.

Signed-off-by: Andrew Thornton <[email protected]>
Co-authored-by: Lunny Xiao <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants