Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support comma-delimited string as labels in issue template #21831

Merged
merged 16 commits into from
Nov 19, 2022
Merged

Support comma-delimited string as labels in issue template #21831

merged 16 commits into from
Nov 19, 2022

Conversation

wolfogre
Copy link
Member

@wolfogre wolfogre commented Nov 16, 2022

The labels in issue YAML templates can be a string array or a comma-delimited string, so a single string should be valid labels.

The old codes committed in #20987 ignore this, that's why the warning is displayed:

image

And it also fixed #17877.

@wolfogre wolfogre added type/bug outdated/backport/v1.18 This PR should be backported to Gitea 1.18 labels Nov 16, 2022
@wolfogre wolfogre added this to the 1.19.0 milestone Nov 16, 2022
@wolfogre wolfogre added the pr/wip This PR is not ready for review label Nov 16, 2022
@wolfogre wolfogre changed the title Support comma-delimited string as labels in issue YAML template Support comma-delimited string as labels in issue template Nov 16, 2022
@wolfogre wolfogre removed the pr/wip This PR is not ready for review label Nov 16, 2022
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 16, 2022
Copy link
Contributor

@wxiaoguang wxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 16, 2022
@wolfogre wolfogre requested a review from lunny November 16, 2022 14:04
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 18, 2022
@zeripath zeripath merged commit d3f850c into go-gitea:main Nov 19, 2022
@wolfogre wolfogre added the backport/done All backports for this PR have been created label Nov 20, 2022
zeripath pushed a commit that referenced this pull request Nov 20, 2022
…21873)

Backport #21831.

The [labels in issue YAML templates](https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/syntax-for-issue-forms#top-level-syntax)
can be a string array or a comma-delimited string, so a single string
should be valid labels.

The old codes committed in #20987 ignore this, that's why the warning is
displayed:

<img width="618" alt="image" src="https://user-images.githubusercontent.com/9418365/202112642-93dc72d0-71c3-40a2-9720-30fc2d48c97c.png">

Fixes #17877.
zjjhot added a commit to zjjhot/gitea that referenced this pull request Nov 21, 2022
* giteaofficial/main:
  Improve documentation for PAM and static deployment (go-gitea#21866)
  Add package registry cleanup rules (go-gitea#21658)
  Support comma-delimited string as labels in issue template (go-gitea#21831)
  Fix wechatwork webhook sends empty content in PR review (go-gitea#21762)
  Show syntax lexer name in file view/blame (go-gitea#21814)
  Add `context.Context` to more methods (go-gitea#21546)
  Timeline and color tweaks (go-gitea#21799)
  Fix webpack license warning (go-gitea#21815)
  chore: add webpack export type check (go-gitea#21857)
  Prevent dangling user redirects (go-gitea#21856)
  Fix "build from source" document to clarify the `bindata` tag is required. (go-gitea#21853)
  Bump loader-utils from 2.0.3 to 2.0.4 (go-gitea#21852)
  Do not allow Ghost access to limited visible user/org (go-gitea#21849)
  Fix setting HTTP headers after write (go-gitea#21833)
fsologureng pushed a commit to fsologureng/gitea that referenced this pull request Nov 22, 2022
…21831)

The [labels in issue YAML
templates](https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/syntax-for-issue-forms#top-level-syntax)
can be a string array or a comma-delimited string, so a single string
should be valid labels.

The old codes committed in go-gitea#20987 ignore this, that's why the warning is
displayed:

<img width="618" alt="image"
src="https://user-images.githubusercontent.com/9418365/202112642-93dc72d0-71c3-40a2-9720-30fc2d48c97c.png">

Fixes go-gitea#17877.
@wolfogre wolfogre mentioned this pull request Dec 3, 2022
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. outdated/backport/v1.18 This PR should be backported to Gitea 1.18 type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue template with empty labels value
6 participants