Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JS dependencies #21881

Merged
merged 5 commits into from
Nov 22, 2022
Merged

Update JS dependencies #21881

merged 5 commits into from
Nov 22, 2022

Conversation

silverwind
Copy link
Member

  • Update all JS deps
  • Regenerate SVGs
  • Add new eslint rules, fix issues
  • Tested Mermaid, Swagger, Vue, Webpack, Citation

@silverwind silverwind changed the title Update JS deps Update JS dependencies Nov 20, 2022
@silverwind silverwind added this to the 1.19.0 milestone Nov 20, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 20, 2022
@delvh
Copy link
Member

delvh commented Nov 20, 2022

… Your PR on khroma was denied… 🥲

@silverwind
Copy link
Member Author

Stubbornly, yes. Hundrets of package manage to have the license field, but there's always that one stupid exception.

@fabiospampinato
Copy link

It's a well motivated reason (fabiospampinato/khroma#33 (comment)), those tools are unreliable almost by definition. But sure, I can understand the frustration.

@silverwind
Copy link
Member Author

Of note is that license-checker-webpack-plugin is primarly there to extract the licenses, the checking functionality is more of a side effect. If in the future we find a way to only extract licenses without checking, I'm happy to switch over to that. Might be necessary anyways once we migrate off webpack.

@fabiospampinato
Copy link

If in the future we find a way to only extract licenses without checking, I'm happy to switch over to that. Might be necessary anyways once we migrate off webpack.

fwiw I'd like to eventually build a standalone little library that given the current package extracts all of its NPM dependencies, detects their repositories, their readmes, their license files, and their license identifier (like just "MIT" rather than the whole string). If you might consider using this and there's some other feature that you'd need just let me know 👍

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 21, 2022
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 21, 2022
- Update all JS deps
- Regenerate SVGs
- Add new eslint rules, fix issues
- Tested Mermaid, Swagger, Vue, Webpack, Citation
@lunny
Copy link
Member

lunny commented Nov 22, 2022

make L-G-T-M work

@lunny lunny merged commit c8b2171 into go-gitea:main Nov 22, 2022
@lunny lunny removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 22, 2022
fsologureng pushed a commit to fsologureng/gitea that referenced this pull request Nov 22, 2022
- Update all JS deps
- Regenerate SVGs
- Add new eslint rules, fix issues
- Tested Mermaid, Swagger, Vue, Webpack, Citation

Co-authored-by: Lunny Xiao <[email protected]>
@silverwind silverwind deleted the deps-44 branch November 22, 2022 03:50
zjjhot added a commit to zjjhot/gitea that referenced this pull request Nov 23, 2022
* giteaofficial/main:
  Handle empty author names (go-gitea#21902)
  Move all remaining colors into CSS variables (go-gitea#21903)
  Add option to enable CAPTCHA validation for login (go-gitea#21638)
  Prepend refs/heads/ to issue template refs (go-gitea#20461)
  Fixes go-gitea#21895: standardize UTC tz for util tests (go-gitea#21897)
  Clarify logging documentation (go-gitea#21665)
  Update JS dependencies (go-gitea#21881)
  Webhook list enhancements (go-gitea#21893)
  Embed Matrix icon as SVG (go-gitea#21890)
  fix(web): add `alt` for logo in home page (go-gitea#21887)
  Improvements for Content Copy (go-gitea#21842)
  Replace yaml.v2 with yaml.v3 (go-gitea#21832)
  Allow disable RSS/Atom feed (go-gitea#21622)
  Consolidate security-check into checks-backend (go-gitea#21882)
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/code-linting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants