Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parallel creating commit status bug with tests (#21911) #21989

Merged
merged 5 commits into from
Dec 13, 2022
Merged

Fix parallel creating commit status bug with tests (#21911) #21989

merged 5 commits into from
Dec 13, 2022

Conversation

lunny
Copy link
Member

@lunny lunny commented Nov 30, 2022 •
edited
Loading

backport #21911
backport #21998

@lunny lunny added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Nov 30, 2022
@lunny lunny added this to the 1.18.0 milestone Nov 30, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Dec 2, 2022
@delvh
Copy link
Member

delvh commented Dec 2, 2022

Should we really backport a test that introduces a data race we haven't been able to fix yet?

@lunny
Copy link
Member Author

lunny commented Dec 2, 2022 •
edited
Loading

I'm waiting #21998

@lunny lunny marked this pull request as ready for review December 3, 2022 03:17
@lunny
Copy link
Member Author

lunny commented Dec 6, 2022

Should we really backport a test that introduces a data race we haven't been able to fix yet?

Looks like the race detection cannot be reproducible every time.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 13, 2022
@lunny lunny merged commit c36a1bc into go-gitea:release/v1.18 Dec 13, 2022
@lunny lunny deleted the lunny/commit_status2 branch December 13, 2022 10:59
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delvh delvh delvh approved these changes

@silverwind silverwind silverwind approved these changes

@wxiaoguang wxiaoguang Awaiting requested review from wxiaoguang

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.18.0
Development

Successfully merging this pull request may close these issues.
4 participants
@lunny @delvh @silverwind @GiteaBot