-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display error log when a modified template has an error so that it could recovery when the error fixed #22261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uld recovery when the error fixed
Codecov Report
@@ Coverage Diff @@
## main #22261 +/- ##
=======================================
Coverage ? 48.11%
=======================================
Files ? 1043
Lines ? 142356
Branches ? 0
=======================================
Hits ? 68499
Misses ? 65673
Partials ? 8184
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
Dec 28, 2022
delvh
reviewed
Dec 28, 2022
Co-authored-by: delvh <[email protected]>
delvh
approved these changes
Dec 28, 2022
GiteaBot
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
Dec 28, 2022
lunny
added
the
skip-changelog
This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
label
Dec 29, 2022
lunny
added
the
outdated/backport/v1.18
This PR should be backported to Gitea 1.18
label
Jan 3, 2023
wolfogre
approved these changes
Jan 3, 2023
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Jan 3, 2023
lunny
added
the
reviewed/wait-merge
This pull request is part of the merge queue. It will be merged soon.
label
Jan 3, 2023
make L-G-T-M work |
lunny
added a commit
to lunny/gitea
that referenced
this pull request
Jan 3, 2023
…uld recovery when the error fixed (go-gitea#22261) A drawback is the previous generated template has been cached, so you cannot get error in the UI but only from log Co-authored-by: KN4CK3R <[email protected]> Co-authored-by: delvh <[email protected]>
lunny
removed
the
reviewed/wait-merge
This pull request is part of the merge queue. It will be merged soon.
label
Jan 3, 2023
lunny
added a commit
that referenced
this pull request
Jan 3, 2023
…uld recovery when the error fixed (#22261) (#22321) backport #22261 A drawback is the previous generated template has been cached, so you cannot get error in the UI but only from log Co-authored-by: KN4CK3R <[email protected]> Co-authored-by: delvh <[email protected]>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jan 4, 2023
* upstream/main: fix: update settings table on install (go-gitea#22326) Use git command instead of exec.Cmd in blame (go-gitea#22098) Display error log when a modified template has an error so that it could recovery when the error fixed (go-gitea#22261)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
backport/done
All backports for this PR have been created
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
outdated/backport/v1.18
This PR should be backported to Gitea 1.18
skip-changelog
This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
type/enhancement
An improvement of existing functionality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A drawback is the previous generated template has been cached, so you cannot get error in the UI but only from log