fix: don't replace err variable in nested check #22416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jolheiser <[email protected]>
GiteaBot
added
the
lgtm/need 1
techknowlogick
approved these changes
Jan 12, 2023
GiteaBot
added
lgtm/done
techknowlogick
added
the
type/refactoring
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jan 13, 2023
* upstream/main: Continue GCing other repos on error in one repo (go-gitea#22422) improve explore relevancy note (go-gitea#22421) fix: don't replace err variable in nested check (go-gitea#22416) Add more packages to denylist (go-gitea#22412) fix wrong theme class when logged out if default theme is changed (go-gitea#22408) Update golang deps (go-gitea#22410)
|
This bug also exists in 1.17 (so I guess also in 1.18) -- worth backporting |
jolheiser
added a commit
to jolheiser/gitea
that referenced
this pull request
Jan 13, 2023
We can use `:=` to make `err` local to the if-scope instead of overwriting the `err` in outer scope. Signed-off-by: jolheiser <[email protected]>
jolheiser
added
backport/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can use
:=to makeerrlocal to the if-scope instead of overwriting theerrin outer scope.