Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pull request API field closed_at always being null #22482

Merged
merged 2 commits into from
Jan 17, 2023
Merged

Fix pull request API field closed_at always being null #22482

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
07e4e61
Fix pull request API field `closed_at` always being `null`
yardenshoham Jan 17, 2023
241f4af
Should be null if it hasn't been closed
yardenshoham Jan 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions services/convert/pull.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ func ToAPIPullRequest(ctx context.Context, pr *issues_model.PullRequest, doer *u
Deadline: apiIssue.Deadline,
Created: pr.Issue.CreatedUnix.AsTimePtr(),
Updated: pr.Issue.UpdatedUnix.AsTimePtr(),
Closed: pr.Issue.ClosedUnix.AsTimePtr(),

AllowMaintainerEdit: pr.AllowMaintainerEdit,

Expand Down