Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs with WebAuthn preventing sign in and registration. #22651

Merged
merged 10 commits into from
Feb 1, 2023

Commits on Jan 29, 2023

  1. Fix Uncaught DOMException: Failed to execute 'atob' on 'Window'

    There is a missing import within the `uint8-to-base64` javascript
    package which assumes that `atob` and `btoa` are present and exported
    instead of using the `window.atob` and `window.btoa` functions. This
    previously worked but as far as I can see things have become more strict
    and this no longer works.
    
    The dependency is small and I do not believe that we gain much from
    having this code as an external dependency. I think instead we should
    just consume this dependency and bring the code directly into Gitea
    itself - the code is itself just some standard incantation for creating
    base64 arrays in javascript.
    
    Therefore this PR simply removes the dependency on `uint8-to-base64` and
    rewrites the functions used in it.
    
    Fix go-gitea#22507
    
    Signed-off-by: Andrew Thornton <[email protected]>
    zeripath committed Jan 29, 2023
    Configuration menu
    Copy the full SHA
    df2adb2 View commit details
    Browse the repository at this point in the history
  2. Update web_src/js/features/user-auth-webauthn.js

    Co-authored-by: delvh <[email protected]>
    zeripath and delvh authored Jan 29, 2023
    Configuration menu
    Copy the full SHA
    f40e516 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    07e40bd View commit details
    Browse the repository at this point in the history
  4. Include findings from go-gitea#22654

    Signed-off-by: Andrew Thornton <[email protected]>
    zeripath committed Jan 29, 2023
    Configuration menu
    Copy the full SHA
    dcd6307 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    4a910b9 View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2023

  1. As per wxiaoguang

    Signed-off-by: Andrew Thornton <[email protected]>
    zeripath committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    f038244 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6326456 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2023

  1. Configuration menu
    Copy the full SHA
    7864ed8 View commit details
    Browse the repository at this point in the history
  2. fix test

    Signed-off-by: Andrew Thornton <[email protected]>
    zeripath committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    b37e6a1 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2023

  1. Configuration menu
    Copy the full SHA
    3bc0753 View commit details
    Browse the repository at this point in the history