-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bugs with WebAuthn preventing sign in and registration. #22651
Merged
Commits on Jan 29, 2023
-
Fix Uncaught DOMException: Failed to execute 'atob' on 'Window'
There is a missing import within the `uint8-to-base64` javascript package which assumes that `atob` and `btoa` are present and exported instead of using the `window.atob` and `window.btoa` functions. This previously worked but as far as I can see things have become more strict and this no longer works. The dependency is small and I do not believe that we gain much from having this code as an external dependency. I think instead we should just consume this dependency and bring the code directly into Gitea itself - the code is itself just some standard incantation for creating base64 arrays in javascript. Therefore this PR simply removes the dependency on `uint8-to-base64` and rewrites the functions used in it. Fix go-gitea#22507 Signed-off-by: Andrew Thornton <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for df2adb2 - Browse repository at this point
Copy the full SHA df2adb2View commit details -
Update web_src/js/features/user-auth-webauthn.js
Co-authored-by: delvh <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f40e516 - Browse repository at this point
Copy the full SHA f40e516View commit details -
Configuration menu - View commit details
-
Copy full SHA for 07e40bd - Browse repository at this point
Copy the full SHA 07e40bdView commit details -
Include findings from go-gitea#22654
Signed-off-by: Andrew Thornton <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for dcd6307 - Browse repository at this point
Copy the full SHA dcd6307View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4a910b9 - Browse repository at this point
Copy the full SHA 4a910b9View commit details
Commits on Jan 30, 2023
-
Signed-off-by: Andrew Thornton <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f038244 - Browse repository at this point
Copy the full SHA f038244View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6326456 - Browse repository at this point
Copy the full SHA 6326456View commit details
Commits on Jan 31, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 7864ed8 - Browse repository at this point
Copy the full SHA 7864ed8View commit details -
Configuration menu - View commit details
-
Copy full SHA for b37e6a1 - Browse repository at this point
Copy the full SHA b37e6a1View commit details
Commits on Feb 1, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 3bc0753 - Browse repository at this point
Copy the full SHA 3bc0753View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.