Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redirect to the commit page after applying patch (#23056) & Fix commit name in Apply Patch page (#23086) #23131

Merged
merged 3 commits into from
Mar 15, 2023
Merged

Redirect to the commit page after applying patch (#23056) & Fix commit name in Apply Patch page (#23086) #23131

merged 3 commits into from
Mar 15, 2023

Conversation

zeripath
Copy link
Contributor

Backport #23056
Backport #23086

Fixes #22621

Fixes
#22621 (comment)

@zeripath zeripath added this to the 1.18.6 milestone Feb 24, 2023
@zeripath zeripath mentioned this pull request Feb 24, 2023
Merged
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 24, 2023
@yp05327
Copy link
Contributor

yp05327 commented Feb 25, 2023

@zeripath
I removed ctx.Data["TreePath"] in the original PR(#23056), since it is not necessary.

@zeripath
Copy link
Contributor Author

@zeripath I removed ctx.Data["TreePath"] in the original PR(#23056), since it is not necessary.

I'm going to leave it in because I do not know if there are templates within in 1.18.x which will need this.

Removing unnecessary values should only be done in major releases - you cannot assume that users do not have templates that rely on these and if they do they will then suffer internal server errors unnecessarily.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 15, 2023
@lunny lunny merged commit 9107a87 into go-gitea:release/v1.18 Mar 15, 2023
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
@zeripath zeripath deleted the backport-23056-v1.18 branch May 10, 2023 17:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@techknowlogick techknowlogick techknowlogick approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.18.6
Development

Successfully merging this pull request may close these issues.
5 participants
@zeripath @yp05327 @lunny @techknowlogick @GiteaBot