Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not create commit graph for temporary repos (#23219) #23302

Merged
merged 3 commits into from
Mar 5, 2023

Conversation

zeripath
Copy link
Contributor

@zeripath zeripath commented Mar 4, 2023

Backport #23219

When fetching remotes for conflict checking, skip unnecessary and potentially slow writing of commit graphs.

In a test with the Blender repository, this reduces conflict checking time for one pull request from about 2s to 0.1s.

brechtvl and others added 2 commits March 1, 2023 19:19
When fetching remotes for conflict checking, skip unnecessary and
potentially slow writing of commit graphs.

In a test with the Blender repository, this reduces conflict checking
time for one pull request from about 2s to 0.1s.
Signed-off-by: Andrew Thornton <[email protected]>
@zeripath zeripath added performance/speed performance issues with slow downs performance/bigrepo Performance Issues affecting Big Repositories labels Mar 4, 2023
@zeripath zeripath added this to the 1.18.6 milestone Mar 4, 2023
@zeripath
Copy link
Contributor Author

zeripath commented Mar 4, 2023

I've restored #23227 and fixed the backport as it was very simple to fix.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 4, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 4, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 4, 2023
@delvh delvh added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 4, 2023
@delvh
Copy link
Member

delvh commented Mar 5, 2023

🎺 🤖

@delvh delvh merged commit 9c33aff into go-gitea:release/v1.18 Mar 5, 2023
@delvh delvh removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 5, 2023
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. performance/bigrepo Performance Issues affecting Big Repositories performance/speed performance issues with slow downs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants