Refactor branch/tag selector dropdown (first step) #23394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxiaoguang
force-pushed
the
refactor-branch-selector
branch
from
f376fd8
to
f178c00
Compare
|
Thanks for untangling this abomination. |
GiteaBot
added
the
lgtm/need 2
silverwind
reviewed
Mar 9, 2023
|
Does it work for all three cases (branch, tag, commit)? |
silverwind
reviewed
Mar 9, 2023
I think yes, feel free to have a try. |
wxiaoguang
force-pushed
the
refactor-branch-selector
branch
from
e9c2ac6
to
703dfd3
Compare
GiteaBot
added
lgtm/need 1
HesterG
reviewed
Mar 10, 2023
wxiaoguang
force-pushed
the
refactor-branch-selector
branch
from
99b961d
to
09422ee
Compare
wxiaoguang
force-pushed
the
refactor-branch-selector
branch
from
09422ee
to
b05907e
Compare
HesterG
approved these changes
Mar 10, 2023
GiteaBot
added
lgtm/done
lafriks
approved these changes
Mar 11, 2023
|
Next: Refactor branch/tag selector to Vue SFC #23421 |
delvh
added
the
type/refactoring
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Mar 13, 2023
* giteaofficial/main: Scoped label display and documentation tweaks (go-gitea#23430) Deduplicate template code for label selection menu (go-gitea#23431) Show edit/close/delete button on organization wide repositories (go-gitea#23388) Sync the class change of Edit Column Button to JS code (go-gitea#23400) Preserve file size when creating attachments (go-gitea#23406) [skip ci] Updated translations via Crowdin Use buildkit for docker builds (go-gitea#23415) Refactor branch/tag selector dropdown (first step) (go-gitea#23394) [skip ci] Updated translations via Crowdin Hide target selector if tag exists when creating new release (go-gitea#23171) Parse external request id from request headers, and print it in access log (go-gitea#22906) Add missing tabs to org projects page (go-gitea#22705) Add user webhooks (go-gitea#21563) Handle OpenID discovery URL errors a little nicer when creating/editing sources (go-gitea#23397) Split CI pipelines (go-gitea#23385)
lunny
pushed a commit
that referenced
this pull request
Mar 14, 2023
Similar to #23394 The dashboard repo list mixes jQuery/Fomantic UI/Vue together, it's very diffcult to maintain and causes unfixable a11y problems. This PR uses two steps to refactor the repo list: 1. move `data-` attributes to JS object and use Vue data as much as possible d3adc0d 2. move the code into a Vue SFC 7ebe55d Total: +516 −585 Screenshots: <details>    </details> --------- Co-authored-by: John Olheiser <[email protected]>
lunny
added a commit
that referenced
this pull request
Mar 14, 2023
Follow #23394 There were many bad smells in old code. This PR only moves the code into Vue SFC, doesn't touch the unrelated logic. update: after 5f23218 , there should be no usage of the vue-rumtime-compiler anymore (hopefully), so I think this PR could close #19851 --------- Co-authored-by: Lunny Xiao <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow:
The branch/tag selector dropdown mixes jQuery/Fomantic UI/Vue together, it's very diffcult to maintain and causes unfixable a11y problems. It also causes problems like #19851 #21314 #21952
This PR is the first step for the refactoring, move
data-attributes to JS object and use Vue data as much as possible.The old selector
'.choose.reference .dropdown'was also wrong, it hits<div class="choose reference"><svg class="dropdown icon">and would cause undefined behaviors.I have done some quick tests and it works. After this PR gets merged, I will move the code into a Vue SFC in next PR.