Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add project type descriptions in issue badge and improve project icons #23437

Merged
merged 15 commits into from
Apr 21, 2023
Merged

Add project type descriptions in issue badge and improve project icons #23437

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
ec6deb9
add project icons to comments
yp05327 Mar 13, 2023
1de9907
improve project icons
yp05327 Mar 13, 2023
81635fc
fix lint
yp05327 Mar 13, 2023
47f09bd
rename project.icon to iconname
yp05327 Mar 14, 2023
0757d69
use tooltips instead of icon
yp05327 Mar 14, 2023
82b643e
Merge branch 'main' into add-project-icon-in-badge
yp05327 Mar 15, 2023
9dea57c
Merge branch 'main' into add-project-icon-in-badge
yp05327 Mar 22, 2023
1d7c2fd
Merge branch 'main' into add-project-icon-in-badge
yp05327 Apr 13, 2023
c0d6f11
fix
yp05327 Apr 14, 2023
37c80ab
add escape
yp05327 Apr 14, 2023
3381eec
Merge branch 'main' into add-project-icon-in-badge
yp05327 Apr 14, 2023
0c8e332
Merge branch 'main' into add-project-icon-in-badge
yp05327 Apr 20, 2023
bad8f07
Merge branch 'main' into add-project-icon-in-badge
wxiaoguang Apr 20, 2023
7327a97
refactor
wxiaoguang Apr 20, 2023
2d80c75
Merge branch 'main' into add-project-icon-in-badge
silverwind Apr 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions options/locale/locale_en-US.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3414,3 +3414,8 @@ runs.invalid_workflow_helper = Workflow config file is invalid. Please check you
runs.no_matching_runner_helper = No matching runner: %s

need_approval_desc = Need approval to run workflows for fork pull request.

[projects]
type-1.display_name = Individual Project
type-2.display_name = Repository Project
type-3.display_name = Organization Project
22 changes: 15 additions & 7 deletions templates/repo/issue/view_content/comments.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -732,14 +732,22 @@
{{template "shared/user/avatarlink" dict "Context" $.Context "user" .Poster}}
<span class="text grey muted-links">
{{template "shared/user/authorlink" .Poster}}
{{if gt .OldProjectID 0}}
{{if gt .ProjectID 0}}
{{$.locale.Tr "repo.issues.change_project_at" (.OldProject.Title|Escape) (.Project.Title|Escape) $createdStr | Safe}}
{{else}}
{{$.locale.Tr "repo.issues.remove_project_at" (.OldProject.Title|Escape) $createdStr | Safe}}
{{end}}
{{$oldProjectDisplayHtml := "Unknown Project"}}
silverwind marked this conversation as resolved.
Show resolved Hide resolved
{{if .OldProject}}
{{$trKey := printf "projects.type-%d.display_name" .OldProject.Type}}
{{$oldProjectDisplayHtml = printf `<span data-tooltip-content="%s">%s</span>` ($.locale.Tr $trKey | Escape) (.OldProject.Title | Escape)}}
{{end}}
{{$newProjectDisplayHtml := "Unknown Project"}}
{{if .Project}}
{{$trKey := printf "projects.type-%d.display_name" .Project.Type}}
{{$newProjectDisplayHtml = printf `<span data-tooltip-content="%s">%s</span>` ($.locale.Tr $trKey | Escape) (.Project.Title | Escape)}}
{{end}}
{{if and (gt .OldProjectID 0) (gt .ProjectID 0)}}
{{$.locale.Tr "repo.issues.change_project_at" $oldProjectDisplayHtml $newProjectDisplayHtml $createdStr | Safe}}
{{else if gt .OldProjectID 0}}
{{$.locale.Tr "repo.issues.remove_project_at" $oldProjectDisplayHtml $createdStr | Safe}}
{{else if gt .ProjectID 0}}
{{$.locale.Tr "repo.issues.add_project_at" (.Project.Title|Escape) $createdStr | Safe}}
{{$.locale.Tr "repo.issues.add_project_at" $newProjectDisplayHtml $createdStr | Safe}}
{{end}}
</span>
</div>
Expand Down