Fix theme-auto loading #23504
Merged
Fix theme-auto loading #23504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix regression from go-gitea#23481. The conditional CSS import was being stripped away by webpack's `css-loader`, resulting in the dark theme always loading. Unfortunately, we have to re-introduce postcss to the CSS pipeline to fix this and I loaded only the minimal plugins to make it work. Related: webpack-contrib/css-loader#1503
Merged
delvh
approved these changes
Mar 15, 2023
GiteaBot
added
the
lgtm/need 1
|
Agree, added the comment. |
jolheiser
approved these changes
Mar 15, 2023
GiteaBot
added
lgtm/done
delvh
added
the
reviewed/wait-merge
jolheiser
removed
the
reviewed/wait-merge
|
Looks we've hit an actual webpack bug, watch webpack-contrib/css-loader#1503 for progress. Once fixed, we should be able to remove postcss again. |
silverwind
added a commit
to silverwind/gitea
that referenced
this pull request
Mar 16, 2023
Fix regression from go-gitea#23481. The conditional on the CSS import was being stripped away by webpack's `css-loader`, resulting in the dark theme always loading. The old syntax with `@import` nested inside `@media` also did not work as `css-loader` (rightfully) ignores such non-standard `@import` syntax that was previously supported by Less. Unfortunately, we have to re-introduce postcss to the CSS pipeline to fix this and I loaded only the minimal plugins to make it work. There is one variant of the fix that does work without postcss, which is to exclude the file from transpilation but I did not consider it as it would have meant the `@import` was being done without a version suffix in the URL, which would have caused cache issue. Related: webpack-contrib/css-loader#1503 --------- Co-authored-by: John Olheiser <[email protected]>
Merged
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Mar 16, 2023
* giteaofficial/main: [skip ci] Updated translations via Crowdin Replace `repo.namedBlob` by `git.TreeEntry`. (go-gitea#22898) Fix theme-auto loading (go-gitea#23504) Update path to docs theme file (go-gitea#23502) Use arm image for arm runner (go-gitea#23503)
techknowlogick
added a commit
that referenced
this pull request
Mar 16, 2023
Follow-up and proper fix for #23504 Update to [[email protected]](https://github.com/webpack-contrib/mini-css-extract-plugin/releases/tag/v2.7.4) which fixes our specific issue described in webpack-contrib/css-loader#1503 and which allows us to again drop the postcss dependency. Backport of this is not necessary as I have included it in #23508. Co-authored-by: techknowlogick <[email protected]>
techknowlogick
pushed a commit
that referenced
this pull request
Mar 17, 2023
Backport #23481, #23504 and #23520 to 1.19, just so we have an easier time with future backports. Seems to work on a basic level. There was a merge conflict in `RepoActionView.vue`, otherwise it merged cleanly. --------- Co-authored-by: John Olheiser <[email protected]> Co-authored-by: Lauris BH <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix regression from #23481.
The conditional on the CSS import was being stripped away by webpack's
css-loader, resulting in the dark theme always loading. The old syntax with@importnested inside@mediaalso did not work ascss-loader(rightfully) ignores such non-standard@importsyntax that was previously supported by Less.Unfortunately, we have to re-introduce postcss to the CSS pipeline to fix this and I loaded only the minimal plugins to make it work.
There is one variant of the fix that does work without postcss, which is to exclude the file from transpilation but I did not consider it as it would have meant the
@importwas being done without a version suffix in the URL, which would have caused cache issue.Related: webpack-contrib/css-loader#1503