Use project.IconName instead of repeated unreadable if-else chains
#23538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
emmmm, I used a new design in #23437 |
GiteaBot
added
the
lgtm/need 2
yp05327
changed the title
delvh
approved these changes
Mar 18, 2023
GiteaBot
added
lgtm/need 1
delvh
added
type/refactoring
delvh
changed the title
project.IconName instead of repeated unreadableif-else chains
delvh
changed the title
project.IconName instead of repeated unreadableif-else chainsproject.IconName instead of repeated unreadable if-else chains
yardenshoham
added
the
lgtm/need 1
|
This PR should be backport to 1.19. Im sorry I made a mistake in old fix here: |
Maybe you can send a standalone PR to fix that and keep this not backport? |
lafriks
approved these changes
Mar 19, 2023
GiteaBot
removed
the
lgtm/need 1
GiteaBot
added
the
lgtm/done
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #23538 +/- ##
==========================================
+ Coverage 47.14% 47.16% +0.02%
==========================================
Files 1149 1154 +5
Lines 151446 152271 +825
==========================================
+ Hits 71397 71825 +428
- Misses 71611 71966 +355
- Partials 8438 8480 +42
... and 11 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Mar 20, 2023
* giteaofficial/main: (23 commits) Display the version of runner in the runner list (go-gitea#23490) Add `.patch` to `attachment.ALLOWED_TYPES` (go-gitea#23580) Sort Python package descriptors by version to mimic PyPI format (go-gitea#23550) Use `project.IconName` instead of repeated unreadable `if-else` chains (go-gitea#23538) Match api migration behavior to web behavior (go-gitea#23552) Fix dropdown icon misalignment when using fomantic icon (go-gitea#23558) Enable color for consistency checks diffs (go-gitea#23563) [skip ci] Updated translations via Crowdin Fix sticky header in diff view (go-gitea#23554) Fix some broken css (go-gitea#23560) Fix JS error on compare page (go-gitea#23551) Upgrade to npm lockfile v3 and explicitely set it (go-gitea#23561) Fix long name ui issues and label ui issue (go-gitea#23541) Remove worker-loader (go-gitea#23548) [skip ci] Updated translations via Crowdin Return `repository` in npm package metadata endpoint (go-gitea#23539) Fix diff detail buttons wrapping, use tippy for review box (go-gitea#23271) Do not store user projects as organization projects (go-gitea#23353) Imrove scroll behavior to hash issuecomment(scroll position, auto expand if file is folded, and on refreshing) (go-gitea#23513) Increase horizontal page padding (go-gitea#23507) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The project type will be changed in #23353, so the old fix #23325 will not work as well.
And I also found that there were some problems in the old fix....