Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match api migration behavior to web behavior (#23552) #23572

Merged
merged 1 commit into from
Mar 19, 2023

Conversation

GiteaBot
Copy link
Contributor

Backport #23552 by @atomaka

When attempting to migrate a repository via the API endpoint comments are always included. This can create a problem if your source repository has issues or pull requests but you do not want to import them into Gitea that displays as something like:

Error 500: We were unable to perform the request due to server-side problems. 'comment references non existent IssueIndex 4

There are only two ways to resolve this:

  1. Migrate using the web interface
  2. Migrate using the API including at issues or pull requests.

This PR matches the behavior of the API migration router to the web migration router.

When attempting to migrate a repository via the API endpoint comments
are always included. This can create a problem if your source repository
has issues or pull requests but you do not want to import them into
Gitea that displays as something like:

> Error 500: We were unable to perform the request due to server-side
problems. 'comment references non existent IssueIndex 4

There are only two ways to resolve this:
1. Migrate using the web interface
2. Migrate using the API including at issues or pull requests.

This PR matches the behavior of the API migration router to the web
migration router.

Co-authored-by: Lauris BH <[email protected]>
Co-authored-by: Lunny Xiao <[email protected]>
@GiteaBot GiteaBot added modifies/api This PR adds API routes or modifies them type/bug labels Mar 19, 2023
@GiteaBot GiteaBot added this to the 1.18.6 milestone Mar 19, 2023
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 19, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 19, 2023
@lunny lunny merged commit efe7561 into go-gitea:release/v1.18 Mar 19, 2023
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants