Fix pagination on /notifications/watching (#23564)
#23603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `q` parameter was not rendered in pagination links because `context.Pagination:AddParam` checks for existance of the parameter in `ctx.Data` where it was absent. Added the parameter there to fix it.
jolheiser
approved these changes
Mar 21, 2023
GiteaBot
added
the
lgtm/need 1
yardenshoham
approved these changes
Mar 21, 2023
GiteaBot
added
lgtm/done
lunny
approved these changes
Mar 21, 2023
lunny
added
the
reviewed/wait-merge
delvh
approved these changes
Mar 21, 2023
|
🎺 🤖 |
jolheiser
removed
the
reviewed/wait-merge
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #23564 by @silverwind
The
qparameter was not rendered in pagination links becausecontext.Pagination:AddParamchecks for existance of the parameter inctx.Datawhere it was absent. Added the parameter there to fix it.