Refactor repo commit list #23690
Merged
Refactor repo commit list #23690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
GiteaBot
added
the
lgtm/need 2
lunny
approved these changes
Mar 27, 2023
GiteaBot
added
lgtm/need 1
lunny
added
the
type/refactoring
delvh
approved these changes
Mar 27, 2023
Comment on lines
+16
to
+17
| {{$commitLink:= printf "%s/commit/%s" $.comment.Issue.PullRequest.BaseRepo.Link (PathEscape .ID.String)}} | ||
|
|
There was a problem hiding this comment.
Why declare it so far above the first usage?
Why not below #34?
There was a problem hiding this comment.
I think it's not that far. The code block looks like this:
{{$commitLink:=....}}
<span class="ui float right shabox">{{$commitLink}}</span> ## The Line 18
<span class="gt-mono commit-summar"..>{{$commitLink}}</span> ## The Line 50
So you can see that now commitLink is at the same level of other blocks.
If we put it below line 34, it would look like
<span class="ui float right shabox">
{{$commitLink := ...}}
{{$commitLink}}
</span>
<span class="gt-mono commit-summar"..>
{{$commitLink}}
</span>
It looks like crossed the code blocks, it doesn't look good to me.
Comment on lines
-33
to
-36
| {{if $.comment.Issue.PullRequest.BaseRepo.Name}} | ||
| <a href="{{$.comment.Issue.PullRequest.BaseRepo.Link}}/commit/{{PathEscape .ID.String}}" rel="nofollow" class="{{$class}}"> | ||
| {{else}} | ||
| <span class="{{$class}}"> |
There was a problem hiding this comment.
Under what condition was that block false?
I don't find any that makes sense, so I'd say this is a reasonable simplification…
GiteaBot
added
lgtm/done
delvh
added
the
reviewed/wait-merge
zeripath
approved these changes
Mar 27, 2023
lunny
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Mar 28, 2023
* upstream/main: Fix issue due date edit toggle bug (go-gitea#23723) Fix profile page email display, respect settings (go-gitea#23747) Update Gitea version in docs (go-gitea#23755) Fix SVG close tag, improve commit graph page UI alignment (go-gitea#23751) Remove incorrect HTML self close tag (go-gitea#23748) Refactor repo commit list (go-gitea#23690) Fix tags view (go-gitea#23243) Add commit info in action page (go-gitea#23210) Use GitHub Actions compatible globbing for `branches`, `tag`, `path` filter (go-gitea#22804)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
if PullRequest.BaseRepo.Namedoesn't make sense, because the$commitLinkis always constructed belowifblocks make the HTML tags (likely) not match in IDE. Although the rendered result matches, it's very unfriendly to editors or code analyzer, and it's difficult to read.After
Move the
$commitLinkassignment ahead.Simplify the code, resolve the above problems.