Don't apply the group filter when listing LDAP group membership if it is empty #23745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is non-empty When running listLdapGroupMemberships check if the groupFilter is empty before using it to list memberships. Fix go-gitea#23615 Signed-off-by: Andrew Thornton <[email protected]>
zeripath
added
type/bug
outdated/backport/v1.19
yardenshoham
approved these changes
Mar 28, 2023
GiteaBot
added
the
lgtm/need 1
lunny
approved these changes
Mar 28, 2023
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
lunny
removed
the
reviewed/wait-merge
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Mar 29, 2023
… is empty (go-gitea#23745) When running listLdapGroupMemberships check if the groupFilter is empty before using it to list memberships. Fix go-gitea#23615 Signed-off-by: Andrew Thornton <[email protected]>
jolheiser
pushed a commit
that referenced
this pull request
Mar 29, 2023
… is empty (#23745) (#23788) Backport #23745 by @zeripath When running listLdapGroupMemberships check if the groupFilter is empty before using it to list memberships. Fix #23615 Signed-off-by: Andrew Thornton <[email protected]> Co-authored-by: zeripath <[email protected]>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Mar 31, 2023
* upstream/main: [skip ci] Updated translations via Crowdin Fix dropdown direction behavior (go-gitea#23806) Fix incorrect/Improve error handle in edit user page (go-gitea#23805) Fix "Updating branch by merge" bug in "update_branch_by_merge.tmpl" (go-gitea#23790) Fix incorrect visibility dropdown list in add/edit user page (go-gitea#23804) Convert issue list checkboxes to native (go-gitea#23596) Fix checks for `needs` in Actions (go-gitea#23789) Diff improvements (go-gitea#23553) [Patch] Fix closed PR also triggers Webhooks and actions (go-gitea#23782) Improve backport-locales.go (go-gitea#23807) [skip ci] Updated translations via Crowdin Refactor commit status for Actions jobs (go-gitea#23786) Add ONLY_SHOW_RELEVANT_REPOS back, fix explore page bug, make code more strict (go-gitea#23766) Don't apply the group filter when listing LDAP group membership if it is empty (go-gitea#23745)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running listLdapGroupMemberships check if the groupFilter is empty before using it to list memberships.
Fix #23615