Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make minio package support legacy MD5 checksum #23768

Merged
merged 8 commits into from
Mar 28, 2023
Merged

Make minio package support legacy MD5 checksum #23768

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
9b09bab
fix
wxiaoguang Mar 28, 2023
0bcac8f
Update modules/storage/minio.go
wxiaoguang Mar 28, 2023
846284c
introduce MINIO_CHECKSUM_ALGORITHM
wxiaoguang Mar 28, 2023
b6dd567
test ci
wxiaoguang Mar 28, 2023
dc7fc8b
fix Save bug caused by MinIO
wxiaoguang Mar 28, 2023
0ff0e7b
fix error check
wxiaoguang Mar 28, 2023
13bdd8a
refactor recordError, delete failed files in Put
wxiaoguang Mar 28, 2023
6b6eac4
Merge branch 'main' into fix-minio-checksum
jolheiser Mar 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion modules/storage/minio.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,14 @@ func (m *MinioStorage) Save(path string, r io.Reader, size int64) (int64, error)
m.buildMinioPath(path),
r,
size,
minio.PutObjectOptions{ContentType: "application/octet-stream"},
minio.PutObjectOptions{
ContentType: "application/octet-stream",
// some storages like:
// * https://developers.cloudflare.com/r2/api/s3/api/
// * https://www.backblaze.com/b2/docs/s3_compatible_api.html
// they do not support "x-amz-checksum-algorithm" header, so use legacy MD5 checksum
wxiaoguang marked this conversation as resolved.
Show resolved Hide resolved
SendContentMd5: true,
},
)
if err != nil {
return 0, convertMinioErr(err)
Expand Down