Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix diff file tree height #23812

Closed
wants to merge 1 commit into from
Closed

Fix diff file tree height #23812

wants to merge 1 commit into from

Conversation

Yiklek
Copy link

@Yiklek Yiklek commented Mar 30, 2023

Fix diff file tree height

Before
image

After
image

@techknowlogick techknowlogick added type/bug topic/ui Change the appearance of the Gitea UI labels Mar 30, 2023
@techknowlogick techknowlogick added this to the 1.20.0 milestone Mar 30, 2023
@silverwind
Copy link
Member

silverwind commented Mar 30, 2023 •
edited
Loading

This PR is duplicate with #23553 that includes a better fix.

I recall 100% height is necessary for correct behaviour when scrolling and using auto regresses it. It was one of the things I tried first.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 30, 2023
@Yiklek Yiklek closed this Mar 30, 2023
@GiteaBot GiteaBot removed this from the 1.20.0 milestone Apr 23, 2023
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Yiklek @silverwind @techknowlogick @GiteaBot