-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert .Source.SkipVerify to $cfg.SkipVerify #23839
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delvh
approved these changes
Mar 31, 2023
GiteaBot
added
the
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
label
Mar 31, 2023
Imho some sources do have skip verify 🤔 |
Codecov Report
@@ Coverage Diff @@
## main #23839 +/- ##
==========================================
- Coverage 47.14% 46.89% -0.25%
==========================================
Files 1149 1158 +9
Lines 151446 153179 +1733
==========================================
+ Hits 71397 71840 +443
- Misses 71611 72850 +1239
- Partials 8438 8489 +51
... and 72 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
lunny
approved these changes
Apr 3, 2023
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Apr 3, 2023
lunny
added
outdated/backport/v1.19
This PR should be backported to Gitea 1.19
reviewed/wait-merge
This pull request is part of the merge queue. It will be merged soon.
and removed
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
labels
Apr 3, 2023
🎺 🤖 |
GiteaBot
added
the
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
label
Apr 3, 2023
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Apr 3, 2023
`Source` doesn't have `SkipVerify`, it is defined in `cfg`
jolheiser
removed
the
reviewed/wait-merge
This pull request is part of the merge queue. It will be merged soon.
label
Apr 3, 2023
jolheiser
pushed a commit
that referenced
this pull request
Apr 3, 2023
Backport #23839 by @yp05327 `Source` doesn't have `SkipVerify`, it is defined in `cfg` Co-authored-by: yp05327 <[email protected]>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Apr 4, 2023
* upstream/main: Use User.ID instead of User.Name in ActivityPub API for Person IRI (go-gitea#23823) Remove fomantic ".link" selector and styles (go-gitea#23888) [skip ci] Updated translations via Crowdin Fix `cases.Title` crash for concurrency (go-gitea#23885) Disable editing tags (go-gitea#23883) Fix user profile description rendering (go-gitea#23882) Introduce GiteaLocaleNumber custom element to handle number localization on pages. (go-gitea#23861) Convert .Source.SkipVerify to $cfg.SkipVerify (go-gitea#23839) Fix review box viewport overflow issue (go-gitea#23800) Fix owner team access mode value in team_unit table (go-gitea#23675) Fix submit button won't refresh in New Repository Fork page (go-gitea#22994) Introduce GitHub markdown editor, keep EasyMDE as fallback (go-gitea#23876) Improve LoadUnitConfig to handle invalid or duplicate units (go-gitea#23736) Append `(comment)` when a link points at a comment rather than the whole issue (go-gitea#23734) Rename actions unit to `repo.actions` and add docs for it (go-gitea#23733) Try to catch more broken translations (go-gitea#23867)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
backport/done
All backports for this PR have been created
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
outdated/backport/v1.19
This PR should be backported to Gitea 1.19
type/bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Source
doesn't haveSkipVerify
, it is defined incfg