Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User/Org Feed render description as per web #23887

Merged
merged 6 commits into from
Apr 4, 2023

Conversation

6543
Copy link
Member

@6543 6543 commented Apr 3, 2023

User descriptions should be rendered so that links and other markup appear correct in RSS feeds.

test will be added by #23874

@6543 6543 added type/bug outdated/backport/v1.19 This PR should be backported to Gitea 1.19 labels Apr 3, 2023
@6543 6543 added this to the 1.20.0 milestone Apr 3, 2023
@6543 6543 requested review from lunny and a team April 3, 2023 05:25
@6543 6543 changed the title User/Org RSS render description as per web User/Org Feed render description as per web Apr 3, 2023
@6543 6543 added the topic/content-rendering Changes how certain filetypes are displayed label Apr 3, 2023
@yardenshoham yardenshoham added backport/manual No power to the bots! Create your backport yourself! and removed backport/manual No power to the bots! Create your backport yourself! labels Apr 3, 2023
@lunny
Copy link
Member

lunny commented Apr 3, 2023

Why is this labeled as a bug?

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 3, 2023
@6543
Copy link
Member Author

6543 commented Apr 3, 2023

because it was never intended to not rendered ... you can consider it a bug or an enhancement

@6543
Copy link
Member Author

6543 commented Apr 3, 2023

@lunny should we use enhancement lable?

is something else blocking/missing?

@silverwind
Copy link
Member

I'm not sure I understand what this does. Any screenshot?

@codecov-commenter

This comment was marked as off-topic.

@6543
Copy link
Member Author

6543 commented Apr 3, 2023

@silverwind well you just need an feed reader or addon, I use https://addons.mozilla.org/en-US/firefox/addon/rsspreview for development

web

image

rss before

image

rss after

image

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 3, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 4, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 4, 2023
@zeripath zeripath merged commit 2c585d6 into go-gitea:main Apr 4, 2023
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Apr 4, 2023
User descriptions should be rendered so that links and other markup
appear correct in RSS feeds.
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Apr 4, 2023
@lunny lunny removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 4, 2023
@6543 6543 deleted the rss_render_user-org_description branch April 4, 2023 04:03
6543 added a commit that referenced this pull request Apr 4, 2023
Backport #23887 by @6543

User descriptions should be rendered so that links and other markup
appear correct in RSS feeds.

test will be added by #23874

Co-authored-by: 6543 <[email protected]>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 5, 2023
* giteaoffical/main:
  Fix image border-radius (go-gitea#23886)
  [skip ci] Updated translations via Crowdin
  Scroll collapsed file into view (go-gitea#23702)
  docs: make the required backticks in email password more explicit (go-gitea#23923)
  docs: fix typo (go-gitea#23924)
  Update docs markdown file weight to make it clear (go-gitea#23909)
  Add activity feeds API (go-gitea#23494)
  Fix code view (diff) broken layout (go-gitea#23096)
  Use ghost user if package creator does not exist (go-gitea#23822)
  Org pages style fixes (go-gitea#23901)
  User/Org Feed render description as per web (go-gitea#23887)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. outdated/backport/v1.19 This PR should be backported to Gitea 1.19 topic/content-rendering Changes how certain filetypes are displayed type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants