Use User.ID instead of User.Name in ActivityPub API for Person IRI (#23823) #23905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o-gitea#23823) Thanks to @trwnh Close go-gitea#23802 The ActivityPub id is an HTTPS URI that should remain constant, even if the user changes their name.
GiteaBot
added
type/bug
skip-changelog
lunny
approved these changes
Apr 4, 2023
GiteaBot
added
the
lgtm/need 1
jolheiser
approved these changes
Apr 4, 2023
GiteaBot
added
lgtm/done
|
This is breaking and should not have been merged in to 1.20 or 1.19. The swagger description for the old path should have been kept in place and the new one added. You cannot just drop API at whim. |
|
The previous implementation is not correct because user's login name could be changed by admin. |
|
Please help to show a case about how it breaks.
If there is really a breaking case, we can simply revert. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #23823 by @wxiaoguang
Thanks to @trwnh
Close #23802
The ActivityPub id is an HTTPS URI that should remain constant, even if the user changes their name.